You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2023/02/15 12:47:47 UTC

[GitHub] [arrow-datafusion] crepererum opened a new pull request, #5288: feat: derive more traits for `ObjectStoreUrl`

crepererum opened a new pull request, #5288:
URL: https://github.com/apache/arrow-datafusion/pull/5288

   # Which issue does this PR close?
   \-
   
   # Rationale for this change
   Improves integration of `ObjectStoreUrl` w/ other code bases.
   
   # What changes are included in this PR?
   Derive the following traits for `ObjectStoreUrl`:
   
   - `Ord`/`PartialOrd`
   - `Eq`/`PartialEq`
   - `Hash`
   
   # Are these changes tested?
   Auto-derive, no testing needed.
   
   # Are there any user-facing changes?
   `ObjectStoreUrl` is better usable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #5288: minor: derive Ord/PartialOrd/Eq/PartialEq traits for `ObjectStoreUrl`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5288:
URL: https://github.com/apache/arrow-datafusion/pull/5288#issuecomment-1431548721

   I think this is a minor PR so merging it in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #5288: minor: derive Ord/PartialOrd/Eq/PartialEq traits for `ObjectStoreUrl`

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5288:
URL: https://github.com/apache/arrow-datafusion/pull/5288#issuecomment-1431555890

   Benchmark runs are scheduled for baseline = 322e92bea6e28ada9f8d57d9429748fb58b2a2a5 and contender = 2b73119bc5bdfd7d1fb9f99ab06964ce810f9ea9. 2b73119bc5bdfd7d1fb9f99ab06964ce810f9ea9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48fba931af2f4ad591ecf539508026de...c90ccf97107340838a6b7eb6947ed0bb/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/df7785515fac4715af62c8893e974975...33aeb38ff55447699c00a9599c36fc5a/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3795f8982c2e497fb360439e4fe3fbce...d6232820f90944389d206f943778cb12/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/83beba4b28444ce6b83585e701677f82...1ae59f2771f2454fae9e219620405415/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #5288: minor: derive Ord/PartialOrd/Eq/PartialEq traits for `ObjectStoreUrl`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5288:
URL: https://github.com/apache/arrow-datafusion/pull/5288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org