You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/08/20 15:46:40 UTC
[PR] [SPARK-58914][CORE][WEBUI] Add a reusable `confirm-link` for Web UI links [spark]
dongjoon-hyun opened a new pull request, #58172:
URL: https://github.com/apache/spark/pull/58172
### What changes were proposed in this pull request?
This PR adds a reusable confirmation prompt for Web UI links:
- `webui.css`: a new `a.confirm-link` style, following the existing `a.kill-link` style.
- `webui.js`: a CSP-compliant delegated click handler for `a.confirm-link[data-confirm-message]`
that shows `window.confirm()` with the message and cancels the navigation when declined.
### Why are the changes needed?
The only existing confirmation pattern, `kill-link`, is tied to the kill-request form submission.
`confirm-link` guards a plain link navigation instead, so any page can add a prompt without a
page-specific inline script, which the Web UI no longer allows under CSP.
### Does this PR introduce _any_ user-facing change?
No. No page renders `confirm-link` yet, so the rendered UI is unchanged.
### How was this patch tested?
Pass the CIs, including `dev/lint-js`.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58914][CORE][WEBUI] Add a reusable `confirm-link` for Web UI links [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58172:
URL: https://github.com/apache/spark/pull/58172#issuecomment-5359513239
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/c9777328627387caa59dc64e7f9e998dfb18c8cb
- merged into branch-4.x https://github.com/apache/spark/commit/2ad4ae1c65bc4e9bfd5d35f4bf371b664891b309
- merged into branch-4.3 https://github.com/apache/spark/commit/1aafc54e2a24c82da91f5132e1d5c62814ae8182
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58914][CORE][WEBUI] Add a reusable `confirm-link` for Web UI links [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #58172: [SPARK-58914][CORE][WEBUI] Add a reusable `confirm-link` for Web UI links
URL: https://github.com/apache/spark/pull/58172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58914][CORE][WEBUI] Add a reusable `confirm-link` for Web UI links [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58172:
URL: https://github.com/apache/spark/pull/58172#issuecomment-5358292965
Could you review this PR, @sarutak ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58914][CORE][WEBUI] Add a reusable `confirm-link` for Web UI links [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58172:
URL: https://github.com/apache/spark/pull/58172#issuecomment-5359481213
Thank you so much, @sarutak !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58914][CORE][WEBUI] Add a reusable `confirm-link` for Web UI links [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58172:
URL: https://github.com/apache/spark/pull/58172#issuecomment-5359504409
This touches only `webui.css` and `webui.js` UI resources and UI test passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org