You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2021/12/22 16:39:52 UTC
[superset] 01/04: Update existing tests
This is an automated email from the ASF dual-hosted git repository.
beto pushed a commit to branch ch24621b
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 5c40ab373502e1292afd44721e3180eae47d256b
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Thu Dec 9 18:38:07 2021 -0800
Update existing tests
---
tests/integration_tests/reports/commands_tests.py | 57 +++++++++++++++++------
1 file changed, 44 insertions(+), 13 deletions(-)
diff --git a/tests/integration_tests/reports/commands_tests.py b/tests/integration_tests/reports/commands_tests.py
index 0e455b3..119ca6f 100644
--- a/tests/integration_tests/reports/commands_tests.py
+++ b/tests/integration_tests/reports/commands_tests.py
@@ -368,7 +368,9 @@ def create_alert_slack_chart_success():
@pytest.fixture(
- params=["alert1",]
+ params=[
+ "alert1",
+ ]
)
def create_alert_slack_chart_grace(request):
param_config = {
@@ -645,7 +647,9 @@ def create_invalid_sql_alert_email_chart(request):
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_email_chart_report_schedule(
- screenshot_mock, email_mock, create_report_email_chart,
+ screenshot_mock,
+ email_mock,
+ create_report_email_chart,
):
"""
ExecuteReport Command: Test chart email report schedule with screenshot
@@ -684,7 +688,9 @@ def test_email_chart_report_schedule(
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_email_chart_alert_schedule(
- screenshot_mock, email_mock, create_alert_email_chart,
+ screenshot_mock,
+ email_mock,
+ create_alert_email_chart,
):
"""
ExecuteReport Command: Test chart email alert schedule with screenshot
@@ -721,7 +727,9 @@ def test_email_chart_alert_schedule(
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_email_chart_report_dry_run(
- screenshot_mock, email_mock, create_report_email_chart,
+ screenshot_mock,
+ email_mock,
+ create_report_email_chart,
):
"""
ExecuteReport Command: Test chart email report schedule dry run
@@ -746,7 +754,11 @@ def test_email_chart_report_dry_run(
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.csv.get_chart_csv_data")
def test_email_chart_report_schedule_with_csv(
- csv_mock, email_mock, mock_open, mock_urlopen, create_report_email_chart_with_csv,
+ csv_mock,
+ email_mock,
+ mock_open,
+ mock_urlopen,
+ create_report_email_chart_with_csv,
):
"""
ExecuteReport Command: Test chart email report schedule with CSV
@@ -935,7 +947,9 @@ def test_email_dashboard_report_schedule(
@patch("superset.reports.notifications.slack.WebClient.files_upload")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_slack_chart_report_schedule(
- screenshot_mock, file_upload_mock, create_report_slack_chart,
+ screenshot_mock,
+ file_upload_mock,
+ create_report_slack_chart,
):
"""
ExecuteReport Command: Test chart slack report schedule
@@ -1154,7 +1168,9 @@ def test_report_schedule_success_grace_end(
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_alert_limit_is_applied(
- screenshot_mock, email_mock, create_alert_email_chart,
+ screenshot_mock,
+ email_mock,
+ create_alert_email_chart,
):
"""
ExecuteReport Command: Test that all alerts apply a SQL limit to stmts
@@ -1210,7 +1226,9 @@ def test_email_dashboard_report_fails(
ALERTS_ATTACH_REPORTS=True,
)
def test_slack_chart_alert(
- screenshot_mock, email_mock, create_alert_email_chart,
+ screenshot_mock,
+ email_mock,
+ create_alert_email_chart,
):
"""
ExecuteReport Command: Test chart slack alert
@@ -1267,7 +1285,9 @@ def test_slack_chart_alert_no_attachment(email_mock, create_alert_email_chart):
@patch("superset.reports.notifications.slack.WebClient")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_slack_token_callable_chart_report(
- screenshot_mock, slack_client_mock_class, create_report_slack_chart,
+ screenshot_mock,
+ slack_client_mock_class,
+ create_report_slack_chart,
):
"""
ExecuteReport Command: Test chart slack alert (slack token callable)
@@ -1379,7 +1399,11 @@ def test_soft_timeout_screenshot(screenshot_mock, email_mock, create_alert_email
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.csv.get_chart_csv_data")
def test_soft_timeout_csv(
- csv_mock, email_mock, mock_open, mock_urlopen, create_report_email_chart_with_csv,
+ csv_mock,
+ email_mock,
+ mock_open,
+ mock_urlopen,
+ create_report_email_chart_with_csv,
):
"""
ExecuteReport Command: Test fail on generating csv
@@ -1403,7 +1427,8 @@ def test_soft_timeout_csv(
assert email_mock.call_args[0][0] == OWNER_EMAIL
assert_log(
- ReportState.ERROR, error_message="A timeout occurred while generating a csv.",
+ ReportState.ERROR,
+ error_message="A timeout occurred while generating a csv.",
)
@@ -1415,7 +1440,11 @@ def test_soft_timeout_csv(
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.csv.get_chart_csv_data")
def test_generate_no_csv(
- csv_mock, email_mock, mock_open, mock_urlopen, create_report_email_chart_with_csv,
+ csv_mock,
+ email_mock,
+ mock_open,
+ mock_urlopen,
+ create_report_email_chart_with_csv,
):
"""
ExecuteReport Command: Test fail on generating csv
@@ -1600,7 +1629,9 @@ def test_grace_period_error(email_mock, create_invalid_sql_alert_email_chart):
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_grace_period_error_flap(
- screenshot_mock, email_mock, create_invalid_sql_alert_email_chart,
+ screenshot_mock,
+ email_mock,
+ create_invalid_sql_alert_email_chart,
):
"""
ExecuteReport Command: Test alert grace period on error