You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/31 03:48:01 UTC
[GitHub] [arrow-ballista] yahoNanJing opened a new pull request, #485: Add grpc service of cleaning up job shuffle data for the scheduler to make it able to be triggered by client explicitly
yahoNanJing opened a new pull request, #485:
URL: https://github.com/apache/arrow-ballista/pull/485
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #458 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #485: Add grpc service of cleaning up job shuffle data for the scheduler to make it able to be triggered by client explicitly
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #485:
URL: https://github.com/apache/arrow-ballista/pull/485#issuecomment-1299484268
Hi @andygrove, there's some code depending on #472. Better to deal with the #472 first. I'll mark this PR as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #485: Add grpc service of cleaning up job shuffle data for the scheduler to make it able to be triggered by client explicitly
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #485:
URL: https://github.com/apache/arrow-ballista/pull/485#issuecomment-1299335942
@yahoNanJing Is it possible to make this PR independent of https://github.com/apache/arrow-ballista/pull/472 so that it can be reviewed separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #485: Add grpc service of cleaning up job shuffle data for the scheduler to make it able to be triggered by client explicitly
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #485:
URL: https://github.com/apache/arrow-ballista/pull/485#discussion_r1012941123
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -543,6 +543,30 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> SchedulerGrpc
})?;
Ok(Response::new(CancelJobResult { cancelled: true }))
}
+
+ async fn clean_job_data(
+ &self,
+ request: Request<CleanJobDataParams>,
+ ) -> Result<Response<CleanJobDataResult>, Status> {
+ let job_id = request.into_inner().job_id;
+ info!("Received clean data request for job {}", job_id);
+
+ self.query_stage_event_loop
+ .get_sender()
+ .map_err(|e| {
+ let msg = format!("Get query stage event loop error due to {:?}", e);
+ error!("{}", msg);
+ Status::internal(msg)
Review Comment:
minor nit: we could introduce a function to create these `Status` messages to avoid duplicating this block of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove merged pull request #485: Add grpc service of cleaning up job shuffle data for the scheduler to make it able to be triggered by client explicitly
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #485:
URL: https://github.com/apache/arrow-ballista/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org