You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/04/30 15:20:53 UTC
svn commit: r1477618 - in
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list:
CursorableLinkedList.java LazyList.java NodeCachingLinkedList.java
SetUniqueList.java TreeList.java
Author: sebb
Date: Tue Apr 30 13:20:53 2013
New Revision: 1477618
URL: http://svn.apache.org/r1477618
Log:
Fields can be private
Modified:
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/LazyList.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/NodeCachingLinkedList.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TreeList.java
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java?rev=1477618&r1=1477617&r2=1477618&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java Tue Apr 30 13:20:53 2013
@@ -61,7 +61,7 @@ public class CursorableLinkedList<E> ext
private static final long serialVersionUID = 8836393098519411393L;
/** A list of the cursor currently open on this list */
- protected transient List<WeakReference<Cursor<E>>> cursors;
+ private transient List<WeakReference<Cursor<E>>> cursors;
//-----------------------------------------------------------------------
/**
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/LazyList.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/LazyList.java?rev=1477618&r1=1477617&r2=1477618&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/LazyList.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/LazyList.java Tue Apr 30 13:20:53 2013
@@ -63,7 +63,7 @@ public class LazyList<E> extends Abstrac
private static final long serialVersionUID = -1708388017160694542L;
/** The factory to use to lazily instantiate the objects */
- protected final Factory<? extends E> factory;
+ private final Factory<? extends E> factory;
/**
* Factory method to create a lazily instantiating list.
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/NodeCachingLinkedList.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/NodeCachingLinkedList.java?rev=1477618&r1=1477617&r2=1477618&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/NodeCachingLinkedList.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/NodeCachingLinkedList.java Tue Apr 30 13:20:53 2013
@@ -47,24 +47,24 @@ public class NodeCachingLinkedList<E> ex
/**
* The default value for {@link #maximumCacheSize}.
*/
- protected static final int DEFAULT_MAXIMUM_CACHE_SIZE = 20;
+ private static final int DEFAULT_MAXIMUM_CACHE_SIZE = 20;
/**
* The first cached node, or <code>null</code> if no nodes are cached.
* Cached nodes are stored in a singly-linked list with
* <code>next</code> pointing to the next element.
*/
- protected transient Node<E> firstCachedNode;
+ private transient Node<E> firstCachedNode;
/**
* The size of the cache.
*/
- protected transient int cacheSize;
+ private transient int cacheSize;
/**
* The maximum size of the cache.
*/
- protected int maximumCacheSize;
+ private int maximumCacheSize;
//-----------------------------------------------------------------------
/**
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java?rev=1477618&r1=1477617&r2=1477618&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java Tue Apr 30 13:20:53 2013
@@ -54,7 +54,7 @@ public class SetUniqueList<E> extends Ab
private static final long serialVersionUID = 7196982186153478694L;
/** Internal Set to maintain uniqueness. */
- protected final Set<E> set;
+ private final Set<E> set;
/**
* Factory method to create a SetList using the supplied list to retain
@@ -368,8 +368,8 @@ public class SetUniqueList<E> extends Ab
*/
static class SetListIterator<E> extends AbstractIteratorDecorator<E> {
- protected final Set<E> set;
- protected E last = null;
+ private final Set<E> set;
+ private E last = null;
protected SetListIterator(final Iterator<E> it, final Set<E> set) {
super(it);
@@ -396,8 +396,8 @@ public class SetUniqueList<E> extends Ab
static class SetListListIterator<E> extends
AbstractListIteratorDecorator<E> {
- protected final Set<E> set;
- protected E last = null;
+ private final Set<E> set;
+ private E last = null;
protected SetListListIterator(final ListIterator<E> it, final Set<E> set) {
super(it);
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TreeList.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TreeList.java?rev=1477618&r1=1477617&r2=1477618&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TreeList.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/TreeList.java Tue Apr 30 13:20:53 2013
@@ -987,31 +987,31 @@ public class TreeList<E> extends Abstrac
*/
static class TreeListIterator<E> implements ListIterator<E>, OrderedIterator<E> {
/** The parent list */
- protected final TreeList<E> parent;
+ private final TreeList<E> parent;
/**
* Cache of the next node that will be returned by {@link #next()}.
*/
- protected AVLNode<E> next;
+ private AVLNode<E> next;
/**
* The index of the next node to be returned.
*/
- protected int nextIndex;
+ private int nextIndex;
/**
* Cache of the last node that was returned by {@link #next()}
* or {@link #previous()}.
*/
- protected AVLNode<E> current;
+ private AVLNode<E> current;
/**
* The index of the last node that was returned.
*/
- protected int currentIndex;
+ private int currentIndex;
/**
* The modification count that the list is expected to have. If the list
* doesn't have this count, then a
* {@link java.util.ConcurrentModificationException} may be thrown by
* the operations.
*/
- protected int expectedModCount;
+ private int expectedModCount;
/**
* Create a ListIterator for a list.