[GitHub] spark pull request #12669: [SPARK-14902][SQL] Expose RuntimeConfig in SparkS...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12669#discussion_r66798040
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionState.scala ---
    @@ -223,6 +223,7 @@ private[hive] class HiveSessionState(ctx: SQLContext) extends SessionState(ctx)
         conf.getConf(HiveUtils.HIVE_THRIFT_SERVER_ASYNC)
       }
     
    +  // TODO: why do we get this from SparkConf but not SQLConf?
    --- End diff --
    
    @rxin @andrewor14 @yhuai  Can we try to move it to SQLConf in this release? I am just afraid it might be even harder to do it in the future release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org