You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/06 23:33:20 UTC
[GitHub] codecov-io edited a comment on issue #6816: Adding dropdown to
DatasourceControl and ability to change datasource
codecov-io edited a comment on issue #6816: Adding dropdown to DatasourceControl and ability to change datasource
URL: https://github.com/apache/incubator-superset/pull/6816#issuecomment-460880070
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6816?src=pr&el=h1) Report
> Merging [#6816](https://codecov.io/gh/apache/incubator-superset/pull/6816?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ff9506fec229a170b0ad7cdacb1fccfd8eff6ef3?src=pr&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `68.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6816?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6816 +/- ##
==========================================
+ Coverage 56.16% 56.29% +0.13%
==========================================
Files 527 530 +3
Lines 23376 23647 +271
Branches 2794 2801 +7
==========================================
+ Hits 13130 13313 +183
- Misses 9836 9924 +88
Partials 410 410
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6816?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `90% <50%> (-4.45%)` | :arrow_down: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRGF0YXNvdXJjZUNvbnRyb2wuanN4) | `64% <66.66%> (+9.83%)` | :arrow_up: |
| [...et/assets/src/datasource/ChangeDatasourceModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0NoYW5nZURhdGFzb3VyY2VNb2RhbC5qc3g=) | `70.83% <70.83%> (ø)` | |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `94.66% <0%> (-0.99%)` | :arrow_down: |
| [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [.../src/visualizations/core/components/SuperChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9jb3JlL2NvbXBvbmVudHMvU3VwZXJDaGFydC5qc3g=) | `10.2% <0%> (ø)` | :arrow_up: |
| [...rset/assets/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `46.15% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/Rose/Rose.js](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9Sb3NlL1Jvc2UuanM=) | `0% <0%> (ø)` | :arrow_up: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `41.11% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0FsdGVyZWRTbGljZVRhZy5qc3g=) | `98.66% <0%> (ø)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/6816/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6816?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6816?src=pr&el=footer). Last update [ff9506f...eb4f7de](https://codecov.io/gh/apache/incubator-superset/pull/6816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org