You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/18 18:01:08 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
kgabryje opened a new pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (cd36398) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 62.36% -0.71%
==========================================
Files 895 443 -452
Lines 43340 27261 -16079
Branches 4015 0 -4015
==========================================
- Hits 27334 17001 -10333
+ Misses 15828 10260 -5568
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.36% <ø> (-0.85%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.93% <0.00%> (-6.04%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [462 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...cd36398](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527690718
##########
File path: superset-frontend/src/explore/components/AdhocMetricEditPopoverTitle.jsx
##########
@@ -18,7 +18,8 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
-import { FormControl, OverlayTrigger, Tooltip } from 'react-bootstrap';
+import { FormControl } from 'react-bootstrap';
+import Tooltip from 'src/common/components/Tooltip';
Review comment:
Hmm, I see that we have mixed export styles in `common/components` - we use both default and named exports. I also prefer named exports, so I refactored Tooltip and it's usages, but I think that we should do the same for other components in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527690924
##########
File path: superset-frontend/src/common/components/Tooltip.tsx
##########
@@ -21,7 +21,11 @@ import { Tooltip as BaseTooltip } from 'src/common/components';
import { TooltipProps } from 'antd/lib/tooltip';
const Tooltip = (props: TooltipProps) => (
- <BaseTooltip overlayStyle={{ fontSize: '12px' }} {...props} />
+ <BaseTooltip
+ overlayStyle={{ fontSize: '12px', lineHeight: '1.6' }}
Review comment:
Good point!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (e825d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 62.65% -0.42%
==========================================
Files 895 443 -452
Lines 43340 27271 -16069
Branches 4015 0 -4015
==========================================
- Hits 27334 17086 -10248
+ Misses 15828 10185 -5643
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.65% <ø> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <0.00%> (-1.20%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.39% <0.00%> (-0.57%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...e825d64](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-730525994

please make sure spacing above and below the header is equal before merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527997150
##########
File path: superset-frontend/src/SqlLab/components/ColumnElement.tsx
##########
@@ -18,13 +18,47 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
+import { ClassNames } from '@emotion/core';
+import { styled, useTheme } from '@superset-ui/core';
-import { OverlayTrigger, Tooltip } from 'react-bootstrap';
+import { Tooltip } from 'src/common/components/Tooltip';
const propTypes = {
column: PropTypes.object.isRequired,
};
+const StyledTooltip = props => {
+ const theme = useTheme();
+ return (
+ <ClassNames>
Review comment:
Cool, hadn't used that one before! Pretty nifty!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-730569943
@junlincc Done. I used smaller spacing as we discussed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (cd36398) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **increase** coverage by `0.08%`.
> The diff coverage is `88.46%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
+ Coverage 63.06% 63.15% +0.08%
==========================================
Files 895 897 +2
Lines 43340 43469 +129
Branches 4015 4188 +173
==========================================
+ Hits 27334 27453 +119
- Misses 15828 15836 +8
- Partials 178 180 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.86% <88.46%> (+0.03%)` | :arrow_up: |
| python | `63.32% <ø> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.21% <0.00%> (+0.31%)` | :arrow_up: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `70.37% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.83% <ø> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `51.51% <ø> (ø)` | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `80.00% <ø> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `95.45% <88.88%> (-4.55%)` | :arrow_down: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...cd36398](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (e825d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **increase** coverage by `0.06%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
+ Coverage 63.06% 63.13% +0.06%
==========================================
Files 895 897 +2
Lines 43340 43453 +113
Branches 4015 4015
==========================================
+ Hits 27334 27435 +101
- Misses 15828 15840 +12
Partials 178 178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.83% <90.00%> (+<0.01%)` | :arrow_up: |
| python | `63.31% <ø> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.21% <0.00%> (+0.31%)` | :arrow_up: |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `70.37% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.83% <ø> (ø)` | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `80.00% <ø> (ø)` | |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/common/components/Tooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `97.70% <100.00%> (+0.02%)` | :arrow_up: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...e825d64](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527742307
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -484,17 +484,18 @@ a.Link {
margin: 3px 5px;
}
-.tooltip pre {
+.ant-tooltip pre {
Review comment:
There is actually 1 case where the global styles affected tooltips outside of ColumnElement - centering of multiline tooltip, such as here:

It was centered before, now it's aligned to the left... which I think might be more natural? WDYT @rusackas, @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-730510663
Looks good to me. Compared with Master version and do not see regression in UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527255827
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -484,17 +484,18 @@ a.Link {
margin: 3px 5px;
}
-.tooltip pre {
+.ant-tooltip pre {
Review comment:
The less LESS we have, the happier I am! Also excited every time we get to see a LESS color variable replaced with an Emotion theme color :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (2385f87) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **increase** coverage by `0.25%`.
> The diff coverage is `80.59%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
+ Coverage 63.06% 63.32% +0.25%
==========================================
Files 895 443 -452
Lines 43340 27272 -16068
Branches 4015 0 -4015
==========================================
- Hits 27334 17270 -10064
+ Misses 15828 10002 -5826
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.32% <80.59%> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.53% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `75.80% <0.00%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `81.67% <60.00%> (+6.28%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.45% <66.66%> (+0.19%)` | :arrow_up: |
| [...uperset/databases/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `79.31% <79.31%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.39% <81.81%> (-0.57%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <81.81%> (-1.20%)` | :arrow_down: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `86.20% <86.20%> (ø)` | |
| ... and [442 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...4e677f5](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (cd36398) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.01%`.
> The diff coverage is `88.46%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 63.04% -0.02%
==========================================
Files 895 897 +2
Lines 43340 43469 +129
Branches 4015 4188 +173
==========================================
+ Hits 27334 27407 +73
- Misses 15828 15882 +54
- Partials 178 180 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.86% <88.46%> (+0.03%)` | :arrow_up: |
| python | `63.16% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.21% <0.00%> (+0.31%)` | :arrow_up: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `70.37% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.83% <ø> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `51.51% <ø> (ø)` | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `80.00% <ø> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `95.45% <88.88%> (-4.55%)` | :arrow_down: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...cd36398](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (cd36398) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.33%`.
> The diff coverage is `88.46%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 62.73% -0.34%
==========================================
Files 895 897 +2
Lines 43340 43469 +129
Branches 4015 4188 +173
==========================================
- Hits 27334 27269 -65
- Misses 15828 16020 +192
- Partials 178 180 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.86% <88.46%> (+0.03%)` | :arrow_up: |
| python | `62.65% <ø> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.21% <0.00%> (+0.31%)` | :arrow_up: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `70.37% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.83% <ø> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `51.51% <ø> (ø)` | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `80.00% <ø> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `95.45% <88.88%> (-4.55%)` | :arrow_down: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...cd36398](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-733035761
@rusackas I think all concerns have been addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (4e677f5) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 63.01% -0.06%
==========================================
Files 895 443 -452
Lines 43340 27272 -16068
Branches 4015 0 -4015
==========================================
- Hits 27334 17185 -10149
+ Misses 15828 10087 -5741
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.01% <ø> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <0.00%> (-4.14%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.65% <0.00%> (-2.53%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `85.71% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.60% <0.00%> (-1.87%)` | :arrow_down: |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...cd36398](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527256255
##########
File path: superset-frontend/src/common/components/Tooltip.tsx
##########
@@ -21,7 +21,11 @@ import { Tooltip as BaseTooltip } from 'src/common/components';
import { TooltipProps } from 'antd/lib/tooltip';
const Tooltip = (props: TooltipProps) => (
- <BaseTooltip overlayStyle={{ fontSize: '12px' }} {...props} />
+ <BaseTooltip
+ overlayStyle={{ fontSize: '12px', lineHeight: '1.6' }}
Review comment:
should probably use the Theme variables here... maybe `useTheme` would do the trick?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (e825d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **increase** coverage by `4.05%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
+ Coverage 63.06% 67.11% +4.05%
==========================================
Files 895 897 +2
Lines 43340 43461 +121
Branches 4015 4015
==========================================
+ Hits 27334 29171 +1837
+ Misses 15828 14186 -1642
+ Partials 178 104 -74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.26% <83.33%> (?)` | |
| javascript | `62.83% <90.00%> (+<0.01%)` | :arrow_up: |
| python | `63.32% <ø> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.65% <0.00%> (+2.74%)` | :arrow_up: |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `88.88% <ø> (+18.51%)` | :arrow_up: |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `91.66% <ø> (+20.83%)` | :arrow_up: |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `67.81% <ø> (+12.06%)` | :arrow_up: |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `92.00% <ø> (+12.00%)` | :arrow_up: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/common/components/Tooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `97.70% <100.00%> (+0.02%)` | :arrow_up: |
| ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...e825d64](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (cd36398) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.29%`.
> The diff coverage is `88.46%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 62.76% -0.30%
==========================================
Files 895 897 +2
Lines 43340 43469 +129
Branches 4015 4188 +173
==========================================
- Hits 27334 27285 -49
- Misses 15828 16004 +176
- Partials 178 180 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.86% <88.46%> (+0.03%)` | :arrow_up: |
| python | `62.71% <ø> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.21% <0.00%> (+0.31%)` | :arrow_up: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `70.37% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.83% <ø> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `51.51% <ø> (ø)` | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `80.00% <ø> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `95.45% <88.88%> (-4.55%)` | :arrow_down: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...cd36398](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527725153
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -484,17 +484,18 @@ a.Link {
margin: 3px 5px;
}
-.tooltip pre {
+.ant-tooltip pre {
Review comment:
Now these styles are used all over SqlLab, but I wonder if we actually need them for ColumnElement? I think that's the case, so I'm going to make a styled tooltip component only for ColumnElement, but I'd appreciate if you verified that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527261104
##########
File path: superset-frontend/src/explore/components/AdhocMetricEditPopoverTitle.jsx
##########
@@ -18,7 +18,8 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
-import { FormControl, OverlayTrigger, Tooltip } from 'react-bootstrap';
+import { FormControl } from 'react-bootstrap';
+import Tooltip from 'src/common/components/Tooltip';
Review comment:
NIT, but wondering how you feel about this being a default export. I kind of prefer named exports, but I won't lose much sleep over it ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527255370
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -484,17 +484,18 @@ a.Link {
margin: 3px 5px;
}
-.tooltip pre {
+.ant-tooltip pre {
Review comment:
would love to see these styles pulled into an Emotion styles in the component exported in /src/common/components
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -484,17 +484,18 @@ a.Link {
margin: 3px 5px;
}
-.tooltip pre {
+.ant-tooltip pre {
Review comment:
would love to see these styles pulled into an Emotion styles in the AntD component exported in /src/common/components
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (e825d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.03%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 63.03% -0.04%
==========================================
Files 895 897 +2
Lines 43340 43453 +113
Branches 4015 4015
==========================================
+ Hits 27334 27392 +58
- Misses 15828 15883 +55
Partials 178 178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.83% <90.00%> (+<0.01%)` | :arrow_up: |
| python | `63.15% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.21% <0.00%> (+0.31%)` | :arrow_up: |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `70.37% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.83% <ø> (ø)` | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `55.74% <ø> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `80.00% <ø> (ø)` | |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/common/components/Tooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `97.70% <100.00%> (+0.02%)` | :arrow_up: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...e825d64](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (cd36398) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 62.65% -0.42%
==========================================
Files 895 443 -452
Lines 43340 27272 -16068
Branches 4015 0 -4015
==========================================
- Hits 27334 17087 -10247
+ Misses 15828 10185 -5643
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.65% <ø> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <0.00%> (-1.20%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.39% <0.00%> (-0.57%)` | :arrow_down: |
| ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...cd36398](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (e825d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **increase** coverage by `3.92%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
+ Coverage 63.06% 66.99% +3.92%
==========================================
Files 895 897 +2
Lines 43340 43461 +121
Branches 4015 4015
==========================================
+ Hits 27334 29115 +1781
+ Misses 15828 14238 -1590
+ Partials 178 108 -70
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.66% <83.33%> (?)` | |
| javascript | `62.83% <90.00%> (+<0.01%)` | :arrow_up: |
| python | `63.32% <ø> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.43% <0.00%> (+1.52%)` | :arrow_up: |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `88.88% <ø> (+18.51%)` | :arrow_up: |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `91.66% <ø> (+20.83%)` | :arrow_up: |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `67.81% <ø> (+12.06%)` | :arrow_up: |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `92.00% <ø> (+12.00%)` | :arrow_up: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <100.00%> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/common/components/Tooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `97.70% <100.00%> (+0.02%)` | :arrow_up: |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...e825d64](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r529807518
##########
File path: superset-frontend/src/SqlLab/components/ColumnElement.tsx
##########
@@ -18,13 +18,47 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
+import { ClassNames } from '@emotion/core';
+import { styled, useTheme } from '@superset-ui/core';
-import { OverlayTrigger, Tooltip } from 'react-bootstrap';
+import { Tooltip } from 'src/common/components/Tooltip';
const propTypes = {
column: PropTypes.object.isRequired,
};
+const StyledTooltip = (props: any) => {
+ const theme = useTheme();
+ return (
+ <ClassNames>
+ {({ css }) => (
+ <Tooltip
+ overlayClassName={css`
+ .ant-tooltip-inner {
+ max-width: ${theme.gridUnit * 125}px;
+ word-wrap: break-word;
+ text-align: center;
+
+ pre {
+ background: transparent;
+ border: none;
+ text-align: left;
+ color: ${theme.colors.grayscale.light5};
+ font-size: ${theme.typography.sizes.xs}px;
+ }
+ }
+ `}
+ {...props}
+ />
+ )}
+ </ClassNames>
+ );
+};
+
+const Hr = styled.hr`
+ margin-top: ${({ theme }) => theme.gridUnit * 1.5}px;
Review comment:
When running into cases like this, I think we should just "snap" to the nearest grid unit that looks good... in this case either 1 or 2. Then if we ever change gridUnit to 5px to air things out, we won't be in the strange world of half pixels.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (e825d64) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 62.36% -0.71%
==========================================
Files 895 443 -452
Lines 43340 27260 -16080
Branches 4015 0 -4015
==========================================
- Hits 27334 17000 -10334
+ Misses 15828 10260 -5568
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.36% <ø> (-0.86%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.93% <0.00%> (-6.04%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...e825d64](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#issuecomment-729880181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=h1) Report
> Merging [#11737](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=desc) (4e677f5) into [master](https://codecov.io/gh/apache/incubator-superset/commit/01d15f53686fe15fb735d1f8a758017b07c9ec14?el=desc) (01d15f5) will **decrease** coverage by `0.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 63.06% 62.53% -0.53%
==========================================
Files 895 443 -452
Lines 43340 27261 -16079
Branches 4015 0 -4015
==========================================
- Hits 27334 17049 -10285
+ Misses 15828 10212 -5616
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.53% <ø> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.53% <0.00%> (-6.94%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <0.00%> (-4.14%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=footer). Last update [01d15f5...4e677f5](https://codecov.io/gh/apache/incubator-superset/pull/11737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527728835
##########
File path: superset-frontend/src/SqlLab/components/ColumnElement.tsx
##########
@@ -18,13 +18,47 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
+import { ClassNames } from '@emotion/core';
+import { styled, useTheme } from '@superset-ui/core';
-import { OverlayTrigger, Tooltip } from 'react-bootstrap';
+import { Tooltip } from 'src/common/components/Tooltip';
const propTypes = {
column: PropTypes.object.isRequired,
};
+const StyledTooltip = props => {
+ const theme = useTheme();
+ return (
+ <ClassNames>
Review comment:
We can't simply wrap Tooltip in `styled` - here's an explanation https://stackoverflow.com/a/63500556/6881179.
I used Emotion's `ClassNames` instead of mounting a tooltip as a child of trigger node, because I didn't like the idea of Tooltip being a child of span. This feels cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org