You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/02/22 18:14:57 UTC
[GitHub] [cassandra] adelapena commented on a change in pull request #896: Cassandra 16446
adelapena commented on a change in pull request #896:
URL: https://github.com/apache/cassandra/pull/896#discussion_r580447988
##########
File path: src/java/org/apache/cassandra/repair/RepairRunnable.java
##########
@@ -447,13 +448,14 @@ public ListenableFuture apply(List<RepairSessionResult> results)
return Futures.immediateFuture(null);
}
}, MoreExecutors.directExecutor());
- Futures.addCallback(repairResult, new RepairCompleteCallback(parentSession, successfulRanges, startTime, traceState, hasFailure, executor), MoreExecutors.directExecutor());
+ Futures.addCallback(repairResult, new RepairCompleteCallback(parentSession, successfulRanges, preparedEndpoints, startTime, traceState, hasFailure, executor), MoreExecutors.directExecutor());
Review comment:
These are also getting quite long, perhaps we could break them:
```java
Futures.addCallback(repairResult,
new RepairCompleteCallback(parentSession, successfulRanges, preparedEndpoints, startTime, traceState, hasFailure, executor),
MoreExecutors.directExecutor());
```
##########
File path: src/java/org/apache/cassandra/repair/RepairRunnable.java
##########
@@ -393,22 +393,23 @@ private void repair(String[] cfnames, NeighborsAndRanges neighborsAndRanges)
{
if (options.isPreview())
{
- previewRepair(parentSession, creationTimeMillis, neighborsAndRanges.filterCommonRanges(keyspace, cfnames), cfnames);
+ previewRepair(parentSession, creationTimeMillis, neighborsAndRanges.filterCommonRanges(keyspace, cfnames), neighborsAndRanges.participants, cfnames);
Review comment:
Nit: maybe we could break this line, and also the two analogous lines after:
```java
previewRepair(parentSession,
creationTimeMillis,
neighborsAndRanges.filterCommonRanges(keyspace, cfnames),
neighborsAndRanges.participants,
cfnames);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org