You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by za...@apache.org on 2023/02/09 02:48:03 UTC
[hadoop] branch trunk updated: HDFS-16910. Fix incorrectly initializing RandomAccessFile caused flush performance decreased for JN (#5359)
This is an automated email from the ASF dual-hosted git repository.
zanderxu pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new d5c046518e9 HDFS-16910. Fix incorrectly initializing RandomAccessFile caused flush performance decreased for JN (#5359)
d5c046518e9 is described below
commit d5c046518e9b519747d746e233ca256fbd66176d
Author: huhaiyang <hu...@126.com>
AuthorDate: Thu Feb 9 10:47:57 2023 +0800
HDFS-16910. Fix incorrectly initializing RandomAccessFile caused flush performance decreased for JN (#5359)
---
.../apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java | 4 ++--
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java
index c5d7ea7eb41..9dd3c24d5b4 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java
@@ -84,9 +84,9 @@ public class EditLogFileOutputStream extends EditLogOutputStream {
doubleBuf = new EditsDoubleBuffer(size);
RandomAccessFile rp;
if (shouldSyncWritesAndSkipFsync) {
- rp = new RandomAccessFile(name, "rw");
+ rp = new RandomAccessFile(name, "rwd");
} else {
- rp = new RandomAccessFile(name, "rws");
+ rp = new RandomAccessFile(name, "rw");
}
try {
fp = new FileOutputStream(rp.getFD()); // open for append
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml b/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
index 49f75aac955..5643a9b5c5e 100755
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
@@ -2721,10 +2721,10 @@
<description>
Specifies whether to flush edit log file channel. When set, expensive
FileChannel#force calls are skipped and synchronous disk writes are
- enabled instead by opening the edit log file with RandomAccessFile("rws")
+ enabled instead by opening the edit log file with RandomAccessFile("rwd")
flags. This can significantly improve the performance of edit log writes
on the Windows platform.
- Note that the behavior of the "rws" flags is platform and hardware specific
+ Note that the behavior of the "rwd" flags is platform and hardware specific
and might not provide the same level of guarantees as FileChannel#force.
For example, the write will skip the disk-cache on SAS and SCSI devices
while it might not on SATA devices. This is an expert level setting,
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org