You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Thomas Andraschko (JIRA)" <de...@myfaces.apache.org> on 2014/04/23 17:12:19 UTC

[jira] [Comment Edited] (MYFACES-3886) SerializedViewCollection does not update it's _keys list when _serializedViews contains key

    [ https://issues.apache.org/jira/browse/MYFACES-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978284#comment-13978284 ] 

Thomas Andraschko edited comment on MYFACES-3886 at 4/23/14 3:10 PM:
---------------------------------------------------------------------

>From PrimeFaces perspective:

We just open a new dialog each time with a iframe and the URL to the "view to open".
If you open a new one, likely a new windowId will be assigned. Thats by design as it's a new dialog with a new view.

Don't know how we could overcome this limitation and if reusing the windowId for all dialogs is a good way or even a correct solution.



was (Author: tandraschko):
We just open a new dialog each time with a iframe and the URL to the "view to open".
If you open a new one, likely a new windowId will be assigned. Thats by design as it's a new dialog with a new view.

Don't know how we could overcome this limitation and if reusing the windowId for all dialogs is a good way or even a correct solution.


> SerializedViewCollection does not update it's _keys list when _serializedViews contains key
> -------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3886
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3886
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.2.2
>         Environment: PrimeFaces 4.0.12.
>            Reporter: Adam Balazs
>
> When I use DialogFramework (of PrimeFaces), it's adds a new view to the session every time. The problem is that when I post an AJAX request to the original view, the _keys list is not updated, only the view get updated in the _serializedViews map.
> After I reach the limit defined with the org.apache.myfaces.NUMBER_OF_VIEWS_IN_SESSION context-param, MyFaces gets the first element in the _keys list (which is the container view) - assuming that this is the oldest view in the session - and remove the corresponding view from the _serializedViews map by the key. But clearly it is not, as I already posted some AJAX requests to it.
> I think the optimal behavior would be the following: when a view gets an ajax request the code should remove the the key from the _keys list and than add it as a last element.
> The related class is org.apache.myfaces.application.viewstate.SerializedViewCollection at the if condition started at line 87.
> My question is if it is an intended behavior or if it's a bug.



--
This message was sent by Atlassian JIRA
(v6.2#6252)