You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org> on 2006/12/18 05:48:40 UTC
[jira] Created: (MASSEMBLY-170) ManifestCreationFinalizer does not
close File handles causing tests to fail
ManifestCreationFinalizer does not close File handles causing tests to fail
---------------------------------------------------------------------------
Key: MASSEMBLY-170
URL: http://jira.codehaus.org/browse/MASSEMBLY-170
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.2
Environment: Windows XP
Reporter: Baerrach bonDierne
finalizeArchiveCreation creates a FileReader but does not call close, which causes the unit tests to fail because the manifest can not be deleted.
Patches attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-170) ManifestCreationFinalizer does not
close File handles causing tests to fail
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-170?page=all ]
Brett Porter closed MASSEMBLY-170.
----------------------------------
Assignee: Brett Porter
Resolution: Fixed
Fix Version/s: 2.2
applied, thanks. Some notes:
- please honour the formatting conventions
- used IOUtils.close instead
> ManifestCreationFinalizer does not close File handles causing tests to fail
> ---------------------------------------------------------------------------
>
> Key: MASSEMBLY-170
> URL: http://jira.codehaus.org/browse/MASSEMBLY-170
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Environment: Windows XP
> Reporter: Baerrach bonDierne
> Assigned To: Brett Porter
> Fix For: 2.2
>
> Attachments: MASSEMBLY-170-patch.txt
>
>
> finalizeArchiveCreation creates a FileReader but does not call close, which causes the unit tests to fail because the manifest can not be deleted.
> Patches attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-170) ManifestCreationFinalizer does not
close File handles causing tests to fail
Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-170?page=all ]
Baerrach bonDierne updated MASSEMBLY-170:
-----------------------------------------
Attachment: MASSEMBLY-170-patch.txt
> ManifestCreationFinalizer does not close File handles causing tests to fail
> ---------------------------------------------------------------------------
>
> Key: MASSEMBLY-170
> URL: http://jira.codehaus.org/browse/MASSEMBLY-170
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Environment: Windows XP
> Reporter: Baerrach bonDierne
> Attachments: MASSEMBLY-170-patch.txt
>
>
> finalizeArchiveCreation creates a FileReader but does not call close, which causes the unit tests to fail because the manifest can not be deleted.
> Patches attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-170) ManifestCreationFinalizer does
not close File handles causing tests to fail
Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-170?page=comments#action_83413 ]
Baerrach bonDierne commented on MASSEMBLY-170:
----------------------------------------------
I normally honour the formatting, if I am not it probably means the eclipse formatting rules are out of date.
> ManifestCreationFinalizer does not close File handles causing tests to fail
> ---------------------------------------------------------------------------
>
> Key: MASSEMBLY-170
> URL: http://jira.codehaus.org/browse/MASSEMBLY-170
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Environment: Windows XP
> Reporter: Baerrach bonDierne
> Assigned To: Brett Porter
> Fix For: 2.2
>
> Attachments: MASSEMBLY-170-patch.txt
>
>
> finalizeArchiveCreation creates a FileReader but does not call close, which causes the unit tests to fail because the manifest can not be deleted.
> Patches attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-170) ManifestCreationFinalizer does not
close File handles causing tests to fail
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-170:
---------------------------------
Fix Version/s: (was: 2.2)
2.2-beta-1
> ManifestCreationFinalizer does not close File handles causing tests to fail
> ---------------------------------------------------------------------------
>
> Key: MASSEMBLY-170
> URL: http://jira.codehaus.org/browse/MASSEMBLY-170
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Environment: Windows XP
> Reporter: Barrie Treloar
> Assigned To: Brett Porter
> Fix For: 2.2-beta-1
>
> Attachments: MASSEMBLY-170-patch.txt
>
>
> finalizeArchiveCreation creates a FileReader but does not call close, which causes the unit tests to fail because the manifest can not be deleted.
> Patches attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira