[GitHub] [hbase] bharathv commented on a change in pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #3204:
URL: https://github.com/apache/hbase/pull/3204#discussion_r620790281



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##########
@@ -641,8 +641,8 @@ public void removePeer(String id) {
             "and that replication on this peer may not be caught up. peerId=" + id);
       }
       for (ReplicationSourceInterface toRemove : srcToRemove) {
-        toRemove.terminate(terminateMessage);
         closeQueue(toRemove);
+        toRemove.terminate(terminateMessage);

Review comment:
       I'm thinking of ways to do a proper cleanup. My only concern here is this may cause some other problem in the future if we rely on a specific order, let me get back on this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org