You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "a7med3del1973 (via GitHub)" <gi...@apache.org> on 2025/02/06 00:34:17 UTC
[PR] Added @NonNull annotations to dependencies in NotificationApiResource [fineract]
a7med3del1973 opened a new pull request, #4306:
URL: https://github.com/apache/fineract/pull/4306
## Description
- Added NonNull annotation to the dependencies in the NotificationApiResource class it doesn't directly affect the behavior of the code (Note : I'm preparing myself for gsoc so i'm waiting for feedback. The NonNull annotation is a compile-time check provided by Lombok. It ensures that the dependencies injected via the constructor are not null only enforces null safety at runtime. )
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added @NonNull annotations to dependencies in NotificationApiResource [fineract]
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics closed pull request #4306: Added @NonNull annotations to dependencies in NotificationApiResource
URL: https://github.com/apache/fineract/pull/4306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added @NonNull annotations to dependencies in NotificationApiResource [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #4306:
URL: https://github.com/apache/fineract/pull/4306#issuecomment-2639375157
@a7med3del1973 Dear Ahmed,
To be honest with you i am not really see any additional value of the null check on the injected fields here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added @NonNull annotations to dependencies in NotificationApiResource [fineract]
Posted by "a7med3del1973 (via GitHub)" <gi...@apache.org>.
a7med3del1973 commented on PR #4306:
URL: https://github.com/apache/fineract/pull/4306#issuecomment-2639544330
I will try to shift my attention to solving high-priority bugs instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added @NonNull annotations to dependencies in NotificationApiResource [fineract]
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #4306:
URL: https://github.com/apache/fineract/pull/4306#issuecomment-2653892389
I agree, this doesn't really add value to the codebase right now. I'm closing it @a7med3del1973 if you don't mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org