You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/02/20 23:57:55 UTC
[kudu-CR] Change checking for existing OpenSSL init logs at INFO not DFATAL
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6084
Change subject: Change checking for existing OpenSSL init logs at INFO not DFATAL
......................................................................
Change checking for existing OpenSSL init logs at INFO not DFATAL
Crashing the client process is painful for some clients,
e.g. Impala's python tests.
Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
---
M src/kudu/security/openssl_util.cc
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/6084/1
--
To view, visit http://gerrit.cloudera.org:8080/6084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[kudu-CR] Change logging for OpenSSL init checking to WARNING from DFATAL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Change logging for OpenSSL init checking to WARNING from DFATAL
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Change logging for OpenSSL init checking to WARNING from DFATAL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Change logging for OpenSSL init checking to WARNING from DFATAL
......................................................................
Change logging for OpenSSL init checking to WARNING from DFATAL
Crashing the client process is painful for some clients,
e.g. Impala's python tests.
Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
Reviewed-on: http://gerrit.cloudera.org:8080/6084
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/security/openssl_util.cc
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Change checking for existing OpenSSL init logs at INFO not DFATAL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Change checking for existing OpenSSL init logs at INFO not DFATAL
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6084/1/src/kudu/security/openssl_util.cc
File src/kudu/security/openssl_util.cc:
Line 98: LOG(INFO) << "It appears that OpenSSL has been previously initialized by "
nit: I think WARNING is probably better, to increase the chances that the user actually sees it.
--
To view, visit http://gerrit.cloudera.org:8080/6084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Change logging for OpenSSL init checking to WARNING from DFATAL
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: Change logging for OpenSSL init checking to WARNING from DFATAL
......................................................................
Change logging for OpenSSL init checking to WARNING from DFATAL
Crashing the client process is painful for some clients,
e.g. Impala's python tests.
Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
---
M src/kudu/security/openssl_util.cc
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/6084/2
--
To view, visit http://gerrit.cloudera.org:8080/6084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Change checking for existing OpenSSL init logs at INFO not DFATAL
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: Change checking for existing OpenSSL init logs at INFO not DFATAL
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6084/1/src/kudu/security/openssl_util.cc
File src/kudu/security/openssl_util.cc:
Line 98: LOG(INFO) << "It appears that OpenSSL has been previously initialized by "
> nit: I think WARNING is probably better, to increase the chances that the u
Done
--
To view, visit http://gerrit.cloudera.org:8080/6084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I542a4550014916273ffb6d01f18b4123e7ad9144
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes