You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Daniel Templeton (JIRA)" <ji...@apache.org> on 2016/09/07 17:24:20 UTC

[jira] [Commented] (MAPREDUCE-6765) MR should not schedule container requests in cases where reducer or mapper containers demand resource larger than the maximum supported

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471227#comment-15471227 ] 

Daniel Templeton commented on MAPREDUCE-6765:
---------------------------------------------

I share Djikstra's dislike of multiple exit points from a function, especially in this case where the code is explicitly structured as a series of conditionals to avoid having multiple exit points.  In both cases, could you please put the subsequent few lines of code in an _else_ instead of adding the returns?

> MR should not schedule container requests in cases where reducer or mapper containers demand resource larger than the maximum supported
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6765
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6765
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mr-am
>    Affects Versions: 2.7.2
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: mapreduce6765.001.patch
>
>
> When mapper or reducer containers request resource larger than the maxResourceRequest in the cluster, job is to be killed. In such cases, it is unnecessary to still schedule container requests.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org