[GitHub] [flink] twalthr commented on a change in pull request #18464: [FLINK-25769][table] Add internal functions and basic function versioning

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #18464:
URL: https://github.com/apache/flink/pull/18464#discussion_r791415561



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/module/Module.java
##########
@@ -36,17 +36,28 @@
 public interface Module {
 
     /**
-     * List names of all functions in this module.
+     * List names of all functions in this module. It excludes internal functions.
      *
      * @return a set of function names
      */
     default Set<String> listFunctions() {
         return Collections.emptySet();
     }
 
+    /**
+     * List names of all functions in this module. It can include internal functions.
+     *
+     * @return a set of function names
+     */
+    default Set<String> listFunctions(boolean includeInternal) {

Review comment:
       The module system does not the concept of an internal function. Instead it is only able to hide certain functions during listing. I rephrased this part and split it into a separate commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org