You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/08 02:27:02 UTC
[GitHub] [skywalking] wallezhang opened a new pull request #7865: feat: Add ClickHouse ID in component-libraries.yml
wallezhang opened a new pull request #7865:
URL: https://github.com/apache/skywalking/pull/7865
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
Add ClickHouse ID in component-libraries.yml
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #7815 .
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7865: feat: Add ClickHouse ID in component-libraries.yml
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7865:
URL: https://github.com/apache/skywalking/pull/7865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7865: feat: Add ClickHouse ID in component-libraries.yml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7865:
URL: https://github.com/apache/skywalking/pull/7865#discussion_r724663788
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -630,3 +633,4 @@ Component-Server-Mappings:
mssql-jdbc-driver: SqlServer
Psychopg: PostgreSQL
GoMysql: Mysql
+ ClickHouse-jdbc-driver: ClickHouse
Review comment:
You don't have jdbc driver definition, and this driver id should be used in your agent plugin.
Take a reference from MySQL and its driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7865: feat: Add ClickHouse ID in component-libraries.yml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7865:
URL: https://github.com/apache/skywalking/pull/7865#issuecomment-938552343
You could start locally. I assume you change yaml file incorrect. Where is server definition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7865: feat: Add ClickHouse ID in component-libraries.yml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7865:
URL: https://github.com/apache/skywalking/pull/7865#discussion_r724658314
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -386,6 +386,9 @@ Fastjson:
Jackson:
id: 118
languages: Java
+ClickHouse:
Review comment:
This is a server of database, we expect a mapping definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wallezhang commented on pull request #7865: feat: Add ClickHouse ID in component-libraries.yml
Posted by GitBox <gi...@apache.org>.
wallezhang commented on pull request #7865:
URL: https://github.com/apache/skywalking/pull/7865#issuecomment-938541438
@wu-sheng Hi, most of the failed checks are due to the failure of container startup. Where can I see the reasons for the failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org