You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/06/02 20:46:06 UTC

[GitHub] incubator-tinkerpop pull request #326: TINKERPOP-1322 Added ConfigurationCus...

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/326

    TINKERPOP-1322 Added ConfigurationCustomizerCompiler

    https://issues.apache.org/jira/browse/TINKERPOP-1322
    
    This `CustomizerCompiler` implementation makes it possible to set low-level configurations in the `GremlinGroovyScriptEngine` on the Groovy `CompilerConfiguration` which ultimately controls script compilation settings used by the classloader. The most likely feature that someone would use here is the setting of the `ScriptBaseClass` which will let executing scripts inherit some base functionality.
    
    All good with:
    
    ```text
    mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false
    ```
    
    Also performed a manual test with Gremlin Server that worked nicely.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1322

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #326
    
----
commit e32347c13e6c4917ebc691aa70e8531cb6b36e1a
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-06-02T20:39:51Z

    Added ConfigurationCustomizerCompiler
    
    This CustomizerCompiler implementation makes it possible to set low-level configurations in the GremlinGroovyScriptEngine on the Groovy CompilerConfiguration which ultimately controls script compilation settings used by the classloader.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop issue #326: TINKERPOP-1322 Added ConfigurationCustomizer...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/incubator-tinkerpop/pull/326
  
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop issue #326: TINKERPOP-1322 Added ConfigurationCustomizer...

Posted by okram <gi...@git.apache.org>.

Github user okram commented on the issue:

    https://github.com/apache/incubator-tinkerpop/pull/326
  
    VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request #326: TINKERPOP-1322 Added ConfigurationCus...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/326


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---