You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/09/08 18:12:54 UTC

[GitHub] [accumulo] ctubbsii commented on pull request #1702: Clean up KeyExtent

ctubbsii commented on pull request #1702:
URL: https://github.com/apache/accumulo/pull/1702#issuecomment-689049275


   I know this is a big PR, but most of this was done with very simple automated refactorings in the IDE... it just looks like a lot more was done, because KeyExtent is used in a lot of files.
   
   I think these changes are worth it, because they make dealing with KeyExtent a bit less error prone, especially with the various `Text` parameters that had different semantics in the overloaded constructors. Giving names to those overloaded constructors, and eliminating the setters makes this object safer to use.
   
   I'm currently running the full ITs on this before I'd consider merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org