You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/17 02:26:17 UTC
[GitHub] [doris] luozenglin opened a new pull request, #13405: [fix](docs) fix error description of `LDAP_ADMIN_PASSWORD` in the document
luozenglin opened a new pull request, #13405:
URL: https://github.com/apache/doris/pull/13405
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #13405: [fix](docs) fix error description of `LDAP_ADMIN_PASSWORD` in the document
Posted by GitBox <gi...@apache.org>.
xy720 commented on code in PR #13405:
URL: https://github.com/apache/doris/pull/13405#discussion_r997131152
##########
docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/LDAP.md:
##########
@@ -44,12 +44,12 @@ SET LDAP_ADMIN_PASSWORD
1. 设置LDAP管理员密码
```sql
-SET LDAP_ADMIN_PASSWORD = '123456'
+SET LDAP_ADMIN_PASSWORD = PASSWORD('123456')
```
### Keywords
- LDAP
Review Comment:
how about use LDAP,ADMIN,PASSWORD ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #13405: [fix](docs) fix error description of `LDAP_ADMIN_PASSWORD` in the document
Posted by GitBox <gi...@apache.org>.
luozenglin commented on code in PR #13405:
URL: https://github.com/apache/doris/pull/13405#discussion_r997765086
##########
docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/LDAP.md:
##########
@@ -44,12 +44,12 @@ SET LDAP_ADMIN_PASSWORD
1. 设置LDAP管理员密码
```sql
-SET LDAP_ADMIN_PASSWORD = '123456'
+SET LDAP_ADMIN_PASSWORD = PASSWORD('123456')
```
### Keywords
- LDAP
Review Comment:
maybe `LDAP, PASSWORD, LDAP_ADMIN_PASSWORD` is good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 merged pull request #13405: [fix](docs) fix error description of `LDAP_ADMIN_PASSWORD` in the document
Posted by GitBox <gi...@apache.org>.
xy720 merged PR #13405:
URL: https://github.com/apache/doris/pull/13405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org