You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "W-M-R (via GitHub)" <gi...@apache.org> on 2024/10/15 08:44:24 UTC
[PR] audio: add offload underflow msg state [nuttx]
W-M-R opened a new pull request, #14304:
URL: https://github.com/apache/nuttx/pull/14304
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
1. memdump: fix warnings.
3. audio: add offload underflow msg state
## Impact
No
## Testing
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] audio: add offload underflow msg state [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14304:
URL: https://github.com/apache/nuttx/pull/14304#issuecomment-2413319609
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**This PR does not meet the NuttX requirements.**
**Summary:**
* The summary is vague and lacks crucial information:
* **Why** are these changes necessary? Are they bug fixes, optimizations, new features?
* **What** specific warnings are being fixed in `memdump`?
* **How** does the addition of the "offload underflow msg state" in `audio` work? What problem does it solve?
* It lacks links to related NuttX issues or pull requests.
**Impact:**
* Simply stating "No" for all impact points is insufficient. Each point requires justification.
* Even if there is no user-facing impact, the PR should explain why.
* Does the "offload underflow msg state" affect any specific architectures, boards, or drivers?
**Testing:**
* "No" is not an acceptable answer for testing.
* The PR must include:
* Details about the build host and target(s) used for testing.
* Testing logs from **before** and **after** the changes to demonstrate the problem and the solution.
**To improve this PR:**
1. **Provide a detailed summary** explaining the purpose, functionality, and reasoning behind each change.
2. **Address the impact section thoroughly.** Justify each "No" and provide specific details for any "Yes."
3. **Include thorough testing information.** List your testing environment and share logs demonstrating the changes.
By following the NuttX PR requirements and providing complete information, your contribution will be easier to review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] audio: add offload underflow msg state [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14304:
URL: https://github.com/apache/nuttx/pull/14304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] audio: add offload underflow msg state [nuttx]
Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI commented on PR #14304:
URL: https://github.com/apache/nuttx/pull/14304#issuecomment-2413839222
Split to 2 PR, the others not audio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org