You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/10/17 16:04:32 UTC

[GitHub] spark pull request #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 i...

GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/22757

    [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kinesis

    ## What changes were proposed in this pull request?
    
    Also update Kinesis SDK's Jackson to match Spark's
    
    ## How was this patch tested?
    
    Existing tests, including Kinesis ones, which ought to be hereby triggered.
    This was uncovered, I believe, in https://github.com/apache/spark/pull/22729#issuecomment-430666080

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-24601.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22757
    
----
commit 47b890695b445c4c081e78bb4f192ae55a562d63
Author: Sean Owen <se...@...>
Date:   2018-10-17T16:02:59Z

    Also update Kinesis SDK's Jackson to match Spark's

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22757
  
    **[Test build #97498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97498/testReport)** for PR 22757 at commit [`47b8906`](https://github.com/apache/spark/commit/47b890695b445c4c081e78bb4f192ae55a562d63).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22757
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22757
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4062/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22757
  
    CC @Fokko - unfortunately the build didn't catch this one because it didn't know enough to trigger Kinesis tests.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22757
  
    **[Test build #97498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97498/testReport)** for PR 22757 at commit [`47b8906`](https://github.com/apache/spark/commit/47b890695b445c4c081e78bb4f192ae55a562d63).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

Posted by Fokko <gi...@git.apache.org>.

Github user Fokko commented on the issue:

    https://github.com/apache/spark/pull/22757
  
    @srowen I wasn't aware of the Kinesis SDK. Thanks for patching this, looks good.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22757: [SPARK-24601][FOLLOWUP] Update Jackson to 2.9.6 in Kines...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22757
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97498/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org