You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/22 10:14:52 UTC

[GitHub] [incubator-nuttx-apps] Ouss4 opened a new pull request #369: Don't save the command again in the history buffer if it's at the top

Ouss4 opened a new pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369


   ## Summary
   When one command is used several times in a row, all of these iterations will be stored in the history buffer, making it look like the history feature isn't working.
   This PR checks if the current command is already at the top, if so don't save it again.
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 merged pull request #369: Don't save the command again in the history buffer if it's at the top

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 edited a comment on pull request #369: Don't save the command again in the history buffer if it's at the top

Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369#issuecomment-678625000


   > Hi @davids5
   > There was a bunch of globals all related to the history feature, I just grouped them in a struct. Long names were also used there which contributed to some nxstyle long line issues.
   
   Ok Got it. 
   
   Is it ready to go then? Has this been built and tested with all the variants of the Kconfig knob in it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #369: Don't save the command again in the history buffer if it's at the top

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369#issuecomment-678625000


   > Hi @davids5
   > There was a bunch of globals all related to the history feature, I just grouped them in a struct. Long names were also used there which contributed to some nxstyle long line issues.
   
   Ok Got it. 
   
   Is it read to go then? Has this be built and tested with all the variants of the Kconfig knob in it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 edited a comment on pull request #369: Don't save the command again in the history buffer if it's at the top

Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369#issuecomment-678625000


   > Hi @davids5
   > There was a bunch of globals all related to the history feature, I just grouped them in a struct. Long names were also used there which contributed to some nxstyle long line issues.
   
   Ok Got it. 
   
   Is it ready to go then? Has this be built and tested with all the variants of the Kconfig knob in it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #369: Don't save the command again in the history buffer if it's at the top

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369#issuecomment-678623607


   Hi @Ouss4 looking at the comment "system/readline/readline_common.c: Fix nxstyle issues." and the code changes. There was a design change globals to a stuct caught in the commit, Did that need to be split out? 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #369: Don't save the command again in the history buffer if it's at the top

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369#issuecomment-678625691


   > Is it ready to go then? Has this been built and tested with all the variants of the Kconfig knob in it?
   
   Yes, it should be.  The core change is pretty simple.  I've done a bunch of tests with nsh (serial and through telnet).  Disabling/enabling the feature doesn't generate any new warnings/errors.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #369: Don't save the command again in the history buffer if it's at the top

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #369:
URL: https://github.com/apache/incubator-nuttx-apps/pull/369#issuecomment-678624233


   Hi @davids5 
   There was a bunch of globals all related to the history feature, I just grouped them in a struct.  Long names were also used there which contributed to some nxstyle long line issues.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org