You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/07/20 19:21:25 UTC
[kudu-CR](branch-1.18.x) KUDU-3678: Fix PostgreSQL build on MacOS 15
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23200
Change subject: KUDU-3678: Fix PostgreSQL build on MacOS 15
......................................................................
KUDU-3678: Fix PostgreSQL build on MacOS 15
This pulls in a slightly modified patch from postgres to fix detection
of strchrnul() in MacOS 15. MacOS 15.4 now has that function, but
only when MACOSX_DEPLOYMENT_TARGET >= 15.4. Postgres' current
deployment target is 15.0, causing the build to fail.
Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Reviewed-on: http://gerrit.cloudera.org:8080/23197
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 3e93df43ae1b9bfff21af6dd8a0c5c0d43202cf0)
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/postgres-fix-strchrnul-macos-check.patch
2 files changed, 218 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/23200/1
--
To view, visit http://gerrit.cloudera.org:8080/23200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Gerrit-Change-Number: 23200
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Jeffrey Smith <je...@gmail.com>
[kudu-CR](branch-1.18.x) KUDU-3678: Fix PostgreSQL build on MacOS 15
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23200 )
Change subject: KUDU-3678: Fix PostgreSQL build on MacOS 15
......................................................................
KUDU-3678: Fix PostgreSQL build on MacOS 15
This pulls in a slightly modified patch from postgres to fix detection
of strchrnul() in MacOS 15. MacOS 15.4 now has that function, but
only when MACOSX_DEPLOYMENT_TARGET >= 15.4. Postgres' current
deployment target is 15.0, causing the build to fail.
Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Reviewed-on: http://gerrit.cloudera.org:8080/23197
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 3e93df43ae1b9bfff21af6dd8a0c5c0d43202cf0)
Reviewed-on: http://gerrit.cloudera.org:8080/23200
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/postgres-fix-strchrnul-macos-check.patch
2 files changed, 218 insertions(+), 2 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Gerrit-Change-Number: 23200
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.18.x) KUDU-3678: Fix PostgreSQL build on MacOS 15
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23200 )
Change subject: KUDU-3678: Fix PostgreSQL build on MacOS 15
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1588/
--
To view, visit http://gerrit.cloudera.org:8080/23200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Gerrit-Change-Number: 23200
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 20 Jul 2025 19:21:35 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3678: Fix PostgreSQL build on MacOS 15
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: KUDU-3678: Fix PostgreSQL build on MacOS 15
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Gerrit-Change-Number: 23200
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.18.x) KUDU-3678: Fix PostgreSQL build on MacOS 15
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23200 )
Change subject: KUDU-3678: Fix PostgreSQL build on MacOS 15
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1588/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Gerrit-Change-Number: 23200
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sun, 20 Jul 2025 21:44:52 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-3678: Fix PostgreSQL build on MacOS 15
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23200 )
Change subject: KUDU-3678: Fix PostgreSQL build on MacOS 15
......................................................................
Patch Set 1: Verified+1 Code-Review+2
unrelated test failures:
tsan: org.apache.kudu.client.TestSecurity, auto_leader_rebalancer-test.0, kudu-admin-test.5
--
To view, visit http://gerrit.cloudera.org:8080/23200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb27f2d401360da69a6d49b5f33fd472c7083065
Gerrit-Change-Number: 23200
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 09:26:44 +0000
Gerrit-HasComments: No