You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "treblereel (via GitHub)" <gi...@apache.org> on 2025/02/26 20:51:11 UTC
[PR] kie-tools-1846: [kn-plugin-workflow] tests, created by quarkus create… [incubator-kie-tools]
treblereel opened a new pull request, #2939:
URL: https://github.com/apache/incubator-kie-tools/pull/2939
…, are clashing with workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-1846: [kn-plugin-workflow] tests, created by quarkus create… [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #2939:
URL: https://github.com/apache/incubator-kie-tools/pull/2939#discussion_r1972462361
##########
packages/kn-plugin-workflow/pkg/command/quarkus/quarkus_project.go:
##########
@@ -43,7 +43,10 @@ type Repository struct {
Url string
}
-var filesToRemove = []string{"mvnw", "mvnw.cmd", ".mvn"}
+var filesToRemove = []string{"mvnw", "mvnw.cmd", ".mvn",
+ "src/test/java/org/acme/GreetingResourceTest.java",
+ "src/test/java/org/acme/GreetingResourceIT.java",
Review Comment:
Can you also remove the `src/main/java` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-1846: [kn-plugin-workflow] tests, created by quarkus create… [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on code in PR #2939:
URL: https://github.com/apache/incubator-kie-tools/pull/2939#discussion_r1972480959
##########
packages/kn-plugin-workflow/pkg/command/quarkus/quarkus_project.go:
##########
@@ -43,7 +43,10 @@ type Repository struct {
Url string
}
-var filesToRemove = []string{"mvnw", "mvnw.cmd", ".mvn"}
+var filesToRemove = []string{"mvnw", "mvnw.cmd", ".mvn",
+ "src/test/java/org/acme/GreetingResourceTest.java",
+ "src/test/java/org/acme/GreetingResourceIT.java",
Review Comment:
@ricardozanini I would keep MyLivenessCheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-tools-1846: [kn-plugin-workflow] tests, created by quarkus create… [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel merged PR #2939:
URL: https://github.com/apache/incubator-kie-tools/pull/2939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org