You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/15 07:58:40 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #9843:
[FLINK-14296] [Table SQL] Use Optional for optional parameters in parser
module
dawidwys commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334802105
##########
File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -129,7 +133,7 @@ public boolean isIfNotExists() {
public void validate() throws SqlValidateException {
Set<String> columnNames = new HashSet<>();
- if (columnList != null) {
+ if (columnList.size() > 0) {
Review comment:
Correct me if I am wrong but those checks against 0 are useless, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services