[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5123: Fix default value for no dictionary byte column

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #5123: Fix default value for no dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123#discussion_r389196290
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
 ##########
 @@ -208,7 +208,7 @@ public long getLatestIngestionTimestamp() {
         // each forward index entry will contain a 4 byte dictionary ID
         forwardIndexColumnSize = FieldSpec.DataType.INT.size();
         int dictionaryColumnSize;
-        if (dataType == FieldSpec.DataType.STRING) {
+        if (!isFixedWidthColumn) {
 
 Review comment:
   better switch the if/else.
   
   also, good to add BYTES column in the schema for realtime test (can be another PR)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org