You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2009/02/04 20:43:59 UTC
[jira] Created: (JCR-1965) [PATCH] Remove Stutter in ItemValidator
[PATCH] Remove Stutter in ItemValidator
---------------------------------------
Key: JCR-1965
URL: https://issues.apache.org/jira/browse/JCR-1965
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-core
Affects Versions: 1.6.0
Reporter: Dave Brosius
Priority: Trivial
Fix For: 1.6.0
Attachments: remove_stutter.diff
ItemValidator duplicates code for no reason. Remove the duplication
if (permissions > Permission.NONE) {
Path path = item.getPrimaryPath();
if (!accessMgr.isGranted(item.getPrimaryPath(), permissions)) {
return false;
}
to
if (permissions > Permission.NONE) {
Path path = item.getPrimaryPath();
if (!accessMgr.isGranted(path, permissions)) {
return false;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1965) [PATCH] Remove Stutter in ItemValidator
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-1965.
-------------------------
Resolution: Fixed
Assignee: angela
> [PATCH] Remove Stutter in ItemValidator
> ---------------------------------------
>
> Key: JCR-1965
> URL: https://issues.apache.org/jira/browse/JCR-1965
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Dave Brosius
> Assignee: angela
> Priority: Trivial
> Fix For: 1.6.0
>
> Attachments: remove_stutter.diff
>
>
> ItemValidator duplicates code for no reason. Remove the duplication
> if (permissions > Permission.NONE) {
> Path path = item.getPrimaryPath();
> if (!accessMgr.isGranted(item.getPrimaryPath(), permissions)) {
> return false;
> }
> to
> if (permissions > Permission.NONE) {
> Path path = item.getPrimaryPath();
> if (!accessMgr.isGranted(path, permissions)) {
> return false;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1965) [PATCH] Remove Stutter in ItemValidator
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-1965:
------------------------
Affects Version/s: (was: 1.6.0)
> [PATCH] Remove Stutter in ItemValidator
> ---------------------------------------
>
> Key: JCR-1965
> URL: https://issues.apache.org/jira/browse/JCR-1965
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Dave Brosius
> Assignee: angela
> Priority: Trivial
> Fix For: 1.6.0
>
> Attachments: remove_stutter.diff
>
>
> ItemValidator duplicates code for no reason. Remove the duplication
> if (permissions > Permission.NONE) {
> Path path = item.getPrimaryPath();
> if (!accessMgr.isGranted(item.getPrimaryPath(), permissions)) {
> return false;
> }
> to
> if (permissions > Permission.NONE) {
> Path path = item.getPrimaryPath();
> if (!accessMgr.isGranted(path, permissions)) {
> return false;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1965) [PATCH] Remove Stutter in ItemValidator
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated JCR-1965:
------------------------------
Attachment: remove_stutter.diff
> [PATCH] Remove Stutter in ItemValidator
> ---------------------------------------
>
> Key: JCR-1965
> URL: https://issues.apache.org/jira/browse/JCR-1965
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.6.0
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 1.6.0
>
> Attachments: remove_stutter.diff
>
>
> ItemValidator duplicates code for no reason. Remove the duplication
> if (permissions > Permission.NONE) {
> Path path = item.getPrimaryPath();
> if (!accessMgr.isGranted(item.getPrimaryPath(), permissions)) {
> return false;
> }
> to
> if (permissions > Permission.NONE) {
> Path path = item.getPrimaryPath();
> if (!accessMgr.isGranted(path, permissions)) {
> return false;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.