You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/04/08 23:39:00 UTC

[jira] [Work logged] (GOBBLIN-1420) Log uncaught exceptions from StreamModelTaskRunner

     [ https://issues.apache.org/jira/browse/GOBBLIN-1420?focusedWorklogId=579641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-579641 ]

ASF GitHub Bot logged work on GOBBLIN-1420:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Apr/21 23:38
            Start Date: 08/Apr/21 23:38
    Worklog Time Spent: 10m 
      Work Description: sv2000 opened a new pull request #3256:
URL: https://github.com/apache/gobblin/pull/3256


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1420
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   StreamModelTaskRunner submits a thread that consumes and processes records in the streaming mode. Currently, this thread can die silently in case of an uncaught exception (e.g. OOMEs), leaving no trace of the exception. 
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   The proposed change only sets the UncaughtExceptionHandler for the thread created by StreamModelTaskRunner. Existing unit tests should cover the changes proposed in this PR.
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 579641)
    Remaining Estimate: 0h
            Time Spent: 10m

> Log uncaught exceptions from StreamModelTaskRunner
> --------------------------------------------------
>
>                 Key: GOBBLIN-1420
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1420
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-core
>    Affects Versions: 0.16.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Abhishek Tiwari
>            Priority: Major
>             Fix For: 0.16.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> StreamModelTaskRunner submits a thread that consumes and processes records in the streaming mode. Currently, this thread can die silently in case of an uncaught exception (e.g. OOMEs), leaving no trace of the exception. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)