[jira] [Commented] (REEF-841) IIMRUClient design needs improvement

["Markus Weimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956635#comment-14956635 ] 

Markus Weimer commented on REEF-841:
------------------------------------

Regarding b): It would also be nice to have a parameter less version of the {{Submit}} method in {{JobDefinitionBuilder}}:

{code}
IIMRUClient.NewJobDefinitionBuilder()
  .SetSomething(...)
  .SetSomethingElse(...)
  .Submit();
{code}

That way, there are only two "ends" to a chain for calls to a {{JobDefinitionBuilder}}: {{Build()}} which returns the job submission object that can be passed around or {{Submit}} which submits the job to the {{IIMRUClient}} it was created on.

Lastly, I'd suggest renaming {{GetJobDefinitionBuilder}} to {{NewJobDefinitionBuilder}} to convey the fact that a new instance is indeed created on each call.

> IIMRUClient design needs improvement
> ------------------------------------
>
>                 Key: REEF-841
>                 URL: https://issues.apache.org/jira/browse/REEF-841
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET Client
>    Affects Versions: 0.14
>         Environment: c#
>            Reporter: Dhruv Mahajan
>            Assignee: Dhruv Mahajan
>
> The aim of this jira is to improve the IIMRUClient design. Specifically,
> a) IMRUJobDefinitionBuilder is not inherited from any interface. As a result the class is public and this makes it difficult to change the implementation and logic in future. So we will introduce IIMRUJobDefinitionBuilder.
> b) IIMRUClient will have another method: IIMRUJobDefinitionBuilder GetJobDefinitionBuilder() which will give users the IMRU job builder. In addition IIMRUJobDefinitionBuilder will have a method TResult Submit(IIMRUClient) that will give users the convenience to submit jobs in the following manner:
> IIMRUClient.GetJobDefinitionBuilder()
> .Set(.............)
> .Set(..............)
> ...
> ...
> .Submit(IIMRUClient);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)