[kudu-CR] Add a benchmark for CBTree concurrent writes.

["Zoltan Martonka (Code Review)" <ge...@cloudera.org>]

Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 )

Change subject: Add a benchmark for CBTree concurrent writes.
......................................................................


Patch Set 8:

(2 comments)

I think it is cleaner to add it to benchmark suit in a separate commit. 
I checked the Jenkins runs. Only TSAN fails with tests other than this file.
@Alexey, is this ok to override Jenkins results, or should I keep updating until it passes?

http://gerrit.cloudera.org:8080/#/c/21447/4/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:

http://gerrit.cloudera.org:8080/#/c/21447/4/src/kudu/tablet/cbtree-test.cc@57
PS4, Line 57: N
> You could use the same logic to output of hardware_concurrency() as you did
I would like to keep it this way.


http://gerrit.cloudera.org:8080/#/c/21447/8/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:

http://gerrit.cloudera.org:8080/#/c/21447/8/src/kudu/tablet/cbtree-test.cc@924
PS8, Line 924: ConcurrentReadWriteBenchmark
> Don't want to delay your commit.
I would prefer to add it in a separate change. 
I will push the change to gerrit, when this is merged.



-- 
To view, visit http://gerrit.cloudera.org:8080/21447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b0b16e269c70716962fc5ebb4ddca1e2cbe68a4
Gerrit-Change-Number: 21447
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2024 11:04:25 +0000
Gerrit-HasComments: Yes