[GitHub] [jena] afs commented on a change in pull request #977: Various small cleanup things.

[GitBox <gi...@apache.org>]

afs commented on a change in pull request #977:
URL: https://github.com/apache/jena/pull/977#discussion_r605918693



##########
File path: .github/workflows/maven.yml
##########
@@ -1,10 +1,11 @@
 ## Licensed under the terms of http://www.apache.org/licenses/LICENSE-2.0
 
 name: Apache Jena CI
+# Manual
+on: workflow_dispatch
 
-on:
-  push:
-    branches: [ main ]

Review comment:
       GH actions serve multiple purposes and audiences but it is one mechanism. It was the same with travis.
   
   One usage is for contributor-developers who have cloned jena and they are likely not using main but their development branch (looking at our PRs, they have all been developments branches in the cloned repo IIRC). And they should not accidently try to update the snapshots repo. What is more, for these people, it will be running on their github account and action-spend limits.
   
   The other usage is for the project. But (ideally) without exporting the project setup to clones which as far as  I know isn't possible.
   
   The project has Jenkins for various jobs. "main" gets updated when PRs are merged and the Jenkins jobs run. I think deploying to the ASF snapshots repo is easier from Jenkins (security credentials).
   
   Building on "main" is duplicating Jenkins, so we have time to get refine this.
   
   e.g. We could enable on PRs coming in.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org