[jira] [Created] (AMQ-4997) Dead code in VMTransport class

["Yuriy Sidelnikov (JIRA)" <ji...@apache.org>]

Yuriy Sidelnikov created AMQ-4997:
-------------------------------------

             Summary: Dead code in VMTransport class
                 Key: AMQ-4997
                 URL: https://issues.apache.org/jira/browse/AMQ-4997
             Project: ActiveMQ
          Issue Type: Bug
          Components: Broker
    Affects Versions: 5.9.0
            Reporter: Yuriy Sidelnikov
            Priority: Minor


The object with name DISCONNECT is created as 
private static final Object DISCONNECT = new Object();

so it can't be modified of be overwritten somewhere outside this class.

However this reference is used only two times to check if:
public void doDispatch(VMTransport transport, TransportListener transportListener, Object command) {
        if (command == DISCONNECT) {
            transportListener.onException(new TransportDisposedIOException("Peer (" + peer.toString() + ") disposed."));
        } else {
            transport.receiveCounter++;
            transportListener.onCommand(command);
        }
    }

and 
if( command == DISCONNECT ) {
                tl.onException(new TransportDisposedIOException("Peer (" + peer.toString() + ") disposed."));
            } else {
                tl.onCommand(command);
            }
so only one branch of ifs will be run.
Seems as some remnant of modification? 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)