You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2012/03/31 19:42:26 UTC

[jira] [Created] (HDFS-3172) dfs.upgrade.permission is dead code

dfs.upgrade.permission is dead code
-----------------------------------

                 Key: HDFS-3172
                 URL: https://issues.apache.org/jira/browse/HDFS-3172
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: name-node
            Reporter: Eli Collins
            Assignee: Eli Collins
            Priority: Trivial


As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3172:
------------------------------

    Status: Patch Available  (was: Open)
    
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243263#comment-13243263 ] 

Hadoop QA commented on HDFS-3172:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12520795/hdfs-3172.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2141//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2141//console

This message is automatically generated.
                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243288#comment-13243288 ] 

Hudson commented on HDFS-3172:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1972 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1972/])
    HDFS-3172. dfs.upgrade.permission is dead code. Contributed by Eli Collins (Revision 1307888)

     Result = ABORTED
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307888
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/DeprecatedProperties.apt.vm
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HdfsConfiguration.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243735#comment-13243735 ] 

Hudson commented on HDFS-3172:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1037 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1037/])
    HDFS-3172. dfs.upgrade.permission is dead code. Contributed by Eli Collins (Revision 1307888)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307888
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/DeprecatedProperties.apt.vm
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HdfsConfiguration.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243275#comment-13243275 ] 

Hudson commented on HDFS-3172:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #1959 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1959/])
    HDFS-3172. dfs.upgrade.permission is dead code. Contributed by Eli Collins (Revision 1307888)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307888
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/DeprecatedProperties.apt.vm
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HdfsConfiguration.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3172:
------------------------------

    Attachment: hdfs-3172.txt

Patch attached. I'll also remove the reference in DeprecatedProperties.apt.vm in common (not in the patch here so test-patch runs).
                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243255#comment-13243255 ] 

Aaron T. Myers commented on HDFS-3172:
--------------------------------------

Patch looks good to me. +1 pending Jenkins.
                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244565#comment-13244565 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3172:
----------------------------------------------

You took my change in HDFS-3168!  Just kidding ... :)
                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3172:
------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.0
    Target Version/s:   (was: 2.0.0)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

No test because we're removing the option.  Thanks ATM, I've committed this.
                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243721#comment-13243721 ] 

Hudson commented on HDFS-3172:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1002 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1002/])
    HDFS-3172. dfs.upgrade.permission is dead code. Contributed by Eli Collins (Revision 1307888)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307888
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/DeprecatedProperties.apt.vm
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HdfsConfiguration.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3172) dfs.upgrade.permission is dead code

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243273#comment-13243273 ] 

Hudson commented on HDFS-3172:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2034 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2034/])
    HDFS-3172. dfs.upgrade.permission is dead code. Contributed by Eli Collins (Revision 1307888)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307888
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/DeprecatedProperties.apt.vm
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HdfsConfiguration.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

                
> dfs.upgrade.permission is dead code
> -----------------------------------
>
>                 Key: HDFS-3172
>                 URL: https://issues.apache.org/jira/browse/HDFS-3172
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3172.txt
>
>
> As of HDFS-3137 dfs.upgrade.permission is dead code (was only used for upgrading from old, no longer supported releases).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira