You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/05/17 06:48:35 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1491: [CELEBORN-588] Remove test conf's category
AngersZhuuuu opened a new pull request, #1491:
URL: https://github.com/apache/incubator-celeborn/pull/1491
### What changes were proposed in this pull request?
Remove test conf's category to avoid make user confused.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1491: [CELEBORN-588] Remove test conf's category
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1491:
URL: https://github.com/apache/incubator-celeborn/pull/1491#discussion_r1196043486
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1353,7 +1353,7 @@ object CelebornConf extends Logging {
val TEST_RETRY_REVIVE: ConfigEntry[Boolean] =
buildConf("celeborn.test.retryRevive")
- .categories("client")
+ .categories("test")
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1491: [CELEBORN-588] Remove test conf's category
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1491:
URL: https://github.com/apache/incubator-celeborn/pull/1491#issuecomment-1550843451
ping @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1491: [CELEBORN-588] Remove test conf's category
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1491:
URL: https://github.com/apache/incubator-celeborn/pull/1491#issuecomment-1550947790
ping @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1491: [CELEBORN-588] Remove test conf's category
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1491:
URL: https://github.com/apache/incubator-celeborn/pull/1491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1491: [CELEBORN-588] Remove test conf's category
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1491:
URL: https://github.com/apache/incubator-celeborn/pull/1491#discussion_r1196022012
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1353,7 +1353,7 @@ object CelebornConf extends Logging {
val TEST_RETRY_REVIVE: ConfigEntry[Boolean] =
buildConf("celeborn.test.retryRevive")
- .categories("client")
+ .categories("test")
Review Comment:
```suggestion
.internal
.categories("client", "test")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1491: [CELEBORN-588] Remove test conf's category
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1491:
URL: https://github.com/apache/incubator-celeborn/pull/1491#issuecomment-1550860005
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1491?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1491](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1491?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (350b021) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/f83304c337a4ba1b12f29a8a4f3a4b490e048350?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f83304c) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 350b021 differs from pull request most recent head 06df23f. Consider uploading reports for the commit 06df23f to get more accurate results
```diff
@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
+ Coverage 45.09% 45.12% +0.04%
==========================================
Files 160 160
Lines 9696 9700 +4
Branches 957 957
==========================================
+ Hits 4371 4376 +5
+ Misses 5040 5035 -5
- Partials 285 289 +4
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.25% <100.00%> (+0.10%)` | :arrow_up: |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1491/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org