You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/27 13:50:01 UTC

[jira] [Commented] (QPIDJMS-372) [SASL] [XOAUTH2] Access token validation too restrictive

    [ https://issues.apache.org/jira/browse/QPIDJMS-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415643#comment-16415643 ] 

ASF GitHub Bot commented on QPIDJMS-372:
----------------------------------------

GitHub user k-wall opened a pull request:

    https://github.com/apache/qpid-jms/pull/16

    QPIDJMS-372: [SASL] [XOAUTH2] Make access token validation comply wit…

    Makes the client's validation of OAUTH-2 access tokens RFC-6749 compliant.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/k-wall/qpid-jms master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-jms/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit dfc24eeab7f34ad54d3b64201d7a8034802b847b
Author: Keith Wall <kw...@...>
Date:   2018-03-26T22:07:00Z

    QPIDJMS-372: [SASL] [XOAUTH2] Make access token validation comply with RFC-6749.

----


> [SASL] [XOAUTH2] Access token validation too restrictive
> --------------------------------------------------------
>
>                 Key: QPIDJMS-372
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-372
>             Project: Qpid JMS
>          Issue Type: Bug
>          Components: qpid-jms-client
>    Affects Versions: 0.31.0
>            Reporter: Keith Wall
>            Priority: Major
>
> http://qpid.2158936.n2.nabble.com/VOTE-Release-Apache-Qpid-JMS-0-31-0-td7674038.html
> Google's access_tokens from {{/oauth2/v4/token}} use characters drawn from
> outside Base64's 64 character set.   RFC 6749[1] defines an
> access_token element as within {{%x20-7E}}, so the code within
> {{org.apache.qpid.jms.sasl.XOauth2Mechanism#isApplicable}} is too
> restrictive.
> [1] https://tools.ietf.org/html/rfc6749



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org