You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/02/03 21:38:34 UTC
[PR] HDDS-12178. Expand transitive test dependencies [ozone]
adoroszlai opened a new pull request, #7800:
URL: https://github.com/apache/ozone/pull/7800
## What changes were proposed in this pull request?
Some dependencies are added transitively via `hdds-hadoop-dependency-test` and `hdds-test-utils`. This is convenient, but `dependency:analyze` reports (some of) these as "unused, declared" in those two modules and "used, undeclared" at the dependent module. This creates noise in the analysis and makes it harder to spot real issues.
- Add test dependencies as needed by each module.
- Remove dependency on `hdds-test-utils` where it was used only for transitives.
- Completely remove the module `hdds-hadoop-dependency-test`.
- Add `commons-compress` as runtime dependency, because it is required via Hadoop's `FileUtil` even for non-test code.
- `slf4j-reload4j` is also used at runtime.
- Add `junit-jupiter-engine` globally (and ignore it as "unused"), because it is required due to old Surefire version.
https://issues.apache.org/jira/browse/HDDS-12178
## How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/13121513530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12178. Expand transitive test dependencies [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7800:
URL: https://github.com/apache/ozone/pull/7800#issuecomment-2653580718
> is it possible to add common dependencies to the parent pom and avoid duplicating the dependencies in all the submodules?
It is possible to add third-party dependencies, but then all submodules inherit the dependency whether it's used or not. This may be OK for test-only dependencies. Then we need to set `<ignoreNonCompile>` instead of `<ignoreRuntime>`.
I agree that adding common dependencies to each submodule is a bit repetitive. On the other hand, there are far fewer common test dependencies than compile-scoped ones.
Let me know if you still prefer to move them to the root POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12178. Expand transitive test dependencies [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7800:
URL: https://github.com/apache/ozone/pull/7800#issuecomment-2656008187
@nandakumar131 would you like to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12178. Add direct test-scope dependencies, remove hdds-hadoop-dependency-test [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7800:
URL: https://github.com/apache/ozone/pull/7800#issuecomment-2657165197
Thanks @nandakumar131 for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12178. Expand transitive test dependencies [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #7800:
URL: https://github.com/apache/ozone/pull/7800#issuecomment-2653537600
@adoroszlai is it possible to add common dependencies to the parent pom and avoid duplicating the dependencies in all the submodules? This seems too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12178. Add direct test-scope dependencies, remove hdds-hadoop-dependency-test [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #7800:
URL: https://github.com/apache/ozone/pull/7800#issuecomment-2657163049
Thanks @adoroszlai for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12178. Add direct test-scope dependencies, remove hdds-hadoop-dependency-test [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 merged PR #7800:
URL: https://github.com/apache/ozone/pull/7800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12178. Expand transitive test dependencies [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7800:
URL: https://github.com/apache/ozone/pull/7800#issuecomment-2654869770
> add common dependencies to the parent pom and avoid duplicating the dependencies in all the submodules?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org