[jira] Commented: (TS-80) Support regular expressions in the host fields of remap rules

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790550#action_12790550 ] 

Leif Hedstrom commented on TS-80:
---------------------------------

Latest changes look good, r=leif (but see question below).

Tested on FC9 and Ubuntu 9.10 (Ubuntu needs libpcre3-dev).

One question though: We fail if PCRE isn't available, so why even have the define  for HAS_PCRE_H (i.e. the check for pcre.h)? Not that it hurts, but the check for libpcre ought to be enough I'd think? Unless there's a reason for the check on pcre.h, I'd recommend removing it (and I checked, the patch does not use the HAS_PCRE_H define that the check produces).

-- Leif

This is the part of the diff I'm talking about:

 if test "$ac_cv_func_epoll_ctl" = "yes"; then
@@ -509,6 +514,7 @@
                   stropts.h \
                   sys/mount.h \
                   sys/param.h \
+                  pcre.h \
                   ], [], [])


> Support regular expressions in the host fields of remap rules
> -------------------------------------------------------------
>
>                 Key: TS-80
>                 URL: https://issues.apache.org/jira/browse/TS-80
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 2.0a
>            Reporter: Manjesh Nilange
>            Priority: Minor
>             Fix For: 2.0a
>
>         Attachments: regex-support-coding-style.patch, regex-support-final.patch, regex-support.patch
>
>
> Currently, the remap rules cannot have regular expressions in the host fields. Even though regular expressions are supported by the regex_remap plugin for the path and query fields, we need this support in the host field too. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.