You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "wolfboys (via GitHub)" <gi...@apache.org> on 2023/04/03 07:30:04 UTC
[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2557: [Improve] workspace local permission check
wolfboys opened a new pull request, #2557:
URL: https://github.com/apache/incubator-streampark/pull/2557
[Improve] workspace local permission check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2557: [Improve] workspace local permission check
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2557:
URL: https://github.com/apache/incubator-streampark/pull/2557#issuecomment-1494539906
> Is it possible we just change the default value to a folder under current working dir? For example, `workspace.local` = `./streampark_workspace` or just `./workspace`.
ok, It's a good idea!. If we do it in this way, We need to mkdir "workspace" under $APP_HOME, and the program need to recognize the `./` path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] macksonmu merged pull request #2557: [Improve] workspace local permission check
Posted by "macksonmu (via GitHub)" <gi...@apache.org>.
macksonmu merged PR #2557:
URL: https://github.com/apache/incubator-streampark/pull/2557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2557: [Improve] workspace local permission check
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2557:
URL: https://github.com/apache/incubator-streampark/pull/2557#issuecomment-1515822207
> Is it possible we just change the default value to a folder under current working dir? For example, `workspace.local` = `./streampark_workspace` or just `./workspace`.
Thanks for your review, it is not recommended to defined `workspace` directory under the project(`$APP_HOME/workspace`), because users will upload jars to this workspace directory. If the streampark upgraded or redeployed, this path will change, which will lead to The dependency jars in many jobs in the user's historical jobs cannot find the path. Therefore, this path needs to be configured separately. Configured to a safe directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] tisonkun commented on pull request #2557: [Improve] workspace local permission check
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2557:
URL: https://github.com/apache/incubator-streampark/pull/2557#issuecomment-1506164741
```diff
commit ac85eb42fa8334f294a59a511585b0fc4a9f97d7 (HEAD -> workspace)
Author: tison <wa...@gmail.com>
Date: Thu Apr 13 09:00:46 2023 +0800
local dir = workspace
Signed-off-by: tison <wa...@gmail.com>
diff --git a/deploy/helm/streampark/conf/streampark-console-config/application.yml b/deploy/helm/streampark/conf/streampark-console-config/application.yml
index 422fd0ae3..714636563 100755
--- a/deploy/helm/streampark/conf/streampark-console-config/application.yml
+++ b/deploy/helm/streampark/conf/streampark-console-config/application.yml
@@ -83,7 +83,7 @@ streampark:
hadoop-user-name: hdfs
# local workspace, used to store source code and build dir etc.
workspace:
- local: /opt/streampark_workspace
+ local: workspace
remote: hdfs://hdfscluster/streampark # support hdfs:///streampark/ 、 /streampark 、hdfs://host:ip/streampark/
# remote docker register namespace for streampark
```
I guess it's as simple as the patch above. Perhaps you should ensure `streampark.sh` `cd` to `$APP_HOME`. Always the path is resolved against current directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2557: [Improve] workspace local permission check
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2557:
URL: https://github.com/apache/incubator-streampark/pull/2557#issuecomment-1493820236
cc @tisonkun PTAL, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org