You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liancheng <gi...@git.apache.org> on 2016/04/05 15:09:58 UTC

[GitHub] spark pull request: [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite...

GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/12177

    [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite should recover the original FileSystem implementation after overriding it

    ## What changes were proposed in this pull request?
    
    Test case `HDFSMetadataLog: fallback from FileContext to FileSystem` doesn't recover the original `FileSystem` implementation after overriding it with `FakeFileSystem`.
    
    This PR fixes this issue by adding `withHadoopConf` in `SQLTestUtils` and apply it to the aforementioned test case.
    
    ## How was this patch tested?
    
    Using existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark spark-14404-fs-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12177
    
----
commit 2b08a94b88c09a1519761277fbd9792e3c8a2e8a
Author: Cheng Lian <li...@databricks.com>
Date:   2016-04-05T13:06:44Z

    Recovers FS implementation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng closed the pull request at:

    https://github.com/apache/spark/pull/12177


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12177#issuecomment-205837810
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54982/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12177#issuecomment-205837382
  
    **[Test build #54982 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54982/consoleFull)** for PR 12177 at commit [`2b08a94`](https://github.com/apache/spark/commit/2b08a94b88c09a1519761277fbd9792e3c8a2e8a).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12177#issuecomment-205837805
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/12177#issuecomment-205812912
  
    I'm closing this since it's not an issue. The scheme of `FakeFileSystem` is randomly generated, so it doesn't interfere normal execution of other tests. The `withHadoopConf` utility method is being added in other PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14404][SQL][TESTS] HDFSMetadataLogSuite...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12177#issuecomment-205796464
  
    **[Test build #54982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54982/consoleFull)** for PR 12177 at commit [`2b08a94`](https://github.com/apache/spark/commit/2b08a94b88c09a1519761277fbd9792e3c8a2e8a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org