You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/01 14:25:07 UTC

[GitHub] [sling-org-apache-sling-installer-factory-feature] cziegeler commented on a change in pull request #1: SLING-9658 Support binary archives in .far files

cziegeler commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-feature/pull/1#discussion_r481177244



##########
File path: bnd.bnd
##########
@@ -1,2 +1,2 @@
 -includeresource: @org.apache.sling.feature.extension.apiregions-[0-9.]*.jar!/org/apache/sling/feature/extension/apiregions/launcher/LauncherProperties.*
-Conditional-Package: org.apache.sling.feature.extension.apiregions.api
+Conditional-Package: org.apache.sling.feature.extension.apiregions.api,org.apache.felix.utils.manifest

Review comment:
       Can we use the shade plugin to move these classes (the felix ones) to the sling namespace?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org