You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2023/08/10 07:34:06 UTC
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20339
Change subject: KUDU-3502: disable http2 support in libcurl
......................................................................
KUDU-3502: disable http2 support in libcurl
This patch adds '--without-nghttp2' option when building curl.
The http2 feature is not needed for Kudu tests or other cases
so it make senses to remote it to avoid linker errors.
Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/20339/1
--
To view, visit http://gerrit.cloudera.org:8080/20339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3502: disable http2 support in libcurl
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20339 )
Change subject: KUDU-3502: disable http2 support in libcurl
......................................................................
Patch Set 2: Verified+1
unrelated test failure in TabletCopyClientBasicTestModes/TabletCopyClientBasicTest.TestDownloadBlockMayFail/1
--
To view, visit http://gerrit.cloudera.org:8080/20339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 15:45:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20339 )
Change subject: KUDU-3502: disable http2 support in libcurl
......................................................................
Patch Set 2: Code-Review+1
I faced the same build error on M1 macbook. Checked out the patch, and now Kudu is building fine in release mode. Thanks for the fix!
Nit: we should probably cherry this to 1.17 release branch as well.
--
To view, visit http://gerrit.cloudera.org:8080/20339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 14:37:23 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20339 )
Change subject: KUDU-3502: disable http2 support in libcurl
......................................................................
KUDU-3502: disable http2 support in libcurl
This patch adds '--without-nghttp2' option when building curl.
The http2 feature is not needed for Kudu tests or other cases,
so it make senses to remove it to avoid linker errors.
Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Reviewed-on: http://gerrit.cloudera.org:8080/20339
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Marton Greber: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20339
to look at the new patch set (#2).
Change subject: KUDU-3502: disable http2 support in libcurl
......................................................................
KUDU-3502: disable http2 support in libcurl
This patch adds '--without-nghttp2' option when building curl.
The http2 feature is not needed for Kudu tests or other cases,
so it make senses to remove it to avoid linker errors.
Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/20339/2
--
To view, visit http://gerrit.cloudera.org:8080/20339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3502: disable http2 support in libcurl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20339 )
Change subject: KUDU-3502: disable http2 support in libcurl
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4703e8f1d32a3ccd397046e0538a6305645fd70d
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 15:45:53 +0000
Gerrit-HasComments: No