You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/07 21:32:31 UTC
[GitHub] [incubator-pekko-grpc] mdedetrich opened a new pull request, #148: Add signing for release artifacts
mdedetrich opened a new pull request, #148:
URL: https://github.com/apache/incubator-pekko-grpc/pull/148
I havent tried this out yet, mainly just used the instructions from https://docs.gradle.org/current/userguide/signing_plugin.html#sec:signing_publications but I suspect we will find out if the signing works when we get there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #148: Add signing for release artifacts
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko-grpc/pull/148#discussion_r1286791961
##########
gradle-plugin/build.gradle:
##########
@@ -81,6 +82,16 @@ nexusPublishing {
}
}
+Boolean isReleaseVersion = !version.toString().endsWith("SNAPSHOT")
+
+signing {
+ setRequired({
+ isReleaseVersion && gradle.taskGraph.hasTask("publish")
+ })
+ useGpgCmd()
Review Comment:
Gradle will use JVM signing by default, `useGpgCmd()` is set because people such as myself have their signing key stored on a key device (i.e. YubiKey) which doesn't work with JVM signing.
Its also consistent with sbt-gpg (which also uses gpg).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich merged pull request #148: Add signing for release artifacts
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #148:
URL: https://github.com/apache/incubator-pekko-grpc/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #148: Add signing for release artifacts
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko-grpc/pull/148#discussion_r1286791961
##########
gradle-plugin/build.gradle:
##########
@@ -81,6 +82,16 @@ nexusPublishing {
}
}
+Boolean isReleaseVersion = !version.toString().endsWith("SNAPSHOT")
+
+signing {
+ setRequired({
+ isReleaseVersion && gradle.taskGraph.hasTask("publish")
+ })
+ useGpgCmd()
Review Comment:
Gradle will use JVM signing, `useGpgCmd()` is set because people such as myself have their signing key stored on a key device (i.e. YubiKey) which doesn't work with JVM signing.
Its also consistent with sbt-gpg (which also uses gpg).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #148: Add signing for release artifacts
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #148:
URL: https://github.com/apache/incubator-pekko-grpc/pull/148#issuecomment-1668633573
Ill work on this ore tomorrow, seems like we are using such an old version of gradle that the way to setup signing is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org