You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by dvjyothsna <gi...@git.apache.org> on 2018/03/15 20:47:00 UTC
[GitHub] drill pull request #1169: DRILL-6243: Added alert box to confirm shutdown of...
GitHub user dvjyothsna opened a pull request:
https://github.com/apache/drill/pull/1169
DRILL-6243: Added alert box to confirm shutdown of drillbit after cli…
…cking shutdown button
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dvjyothsna/drill DRILL-6243
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1169
----
commit 9b4b0700937e9d155324ebbd119171588dcf97c1
Author: dvjyothsna <ro...@...>
Date: 2018-03-14T23:36:42Z
DRILL-6243: Added alert box to confirm shutdown of drillbit after clicking shutdown button
----
---
[GitHub] drill issue #1169: DRILL-6243: Added alert box to confirm shutdown of drillb...
Posted by sohami <gi...@git.apache.org>.
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1169
+1 LGTM. Thanks for making the changes.
---
[GitHub] drill pull request #1169: DRILL-6243: Added alert box to confirm shutdown of...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1169
---
[GitHub] drill pull request #1169: DRILL-6243: Added alert box to confirm shutdown of...
Posted by sohami <gi...@git.apache.org>.
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1169#discussion_r175598108
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -272,17 +272,19 @@
}
<#if model.shouldShowAdminInfo() || !model.isAuthEnabled()>
function shutdown(button) {
- var requestPath = "/gracefulShutdown";
- var url = getRequestUrl(requestPath);
- var result = $.ajax({
- type: 'POST',
- url: url,
- contentType : 'text/plain',
- complete: function(data) {
- alert(data.responseJSON["response"]);
- button.prop('disabled',true).css('opacity',0.5);
- }
- });
+ if (confirm("Click ok to shutdown")) {
+ var requestPath = "/gracefulShutdown";
+ var url = getRequestUrl(requestPath);
+ var result = $.ajax({
+ type: 'POST',
+ url: url,
+ contentType : 'text/plain',
+ complete: function(data) {
+ alert(data.responseJSON["response"]);
+ button.prop('disabled',true).css('opacity',0.5);
+ }
--- End diff --
please fix indentation here and below. Also add the `error: `callback for Ajax request.
Like alert with received error ?
---
[GitHub] drill issue #1169: DRILL-6243: Added alert box to confirm shutdown of drillb...
Posted by dvjyothsna <gi...@git.apache.org>.
Github user dvjyothsna commented on the issue:
https://github.com/apache/drill/pull/1169
@sohami Please review
---
[GitHub] drill pull request #1169: DRILL-6243: Added alert box to confirm shutdown of...
Posted by sohami <gi...@git.apache.org>.
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1169#discussion_r175598697
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -272,17 +272,19 @@
}
<#if model.shouldShowAdminInfo() || !model.isAuthEnabled()>
function shutdown(button) {
- var requestPath = "/gracefulShutdown";
- var url = getRequestUrl(requestPath);
- var result = $.ajax({
- type: 'POST',
- url: url,
- contentType : 'text/plain',
- complete: function(data) {
- alert(data.responseJSON["response"]);
- button.prop('disabled',true).css('opacity',0.5);
- }
- });
+ if (confirm("Click ok to shutdown")) {
--- End diff --
Message should be more of like` "Are you sure you want to shutdown Drillbit running on + location.host + node ?"`
---