You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Rowe (JIRA)" <ji...@apache.org> on 2008/04/01 02:04:25 UTC

[jira] Created: (LUCENE-1256) Changes.html formatting improvements

Changes.html formatting improvements
------------------------------------

                 Key: LUCENE-1256
                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Build
    Affects Versions: 2.4
            Reporter: Steven Rowe
            Priority: Trivial
             Fix For: 2.4
         Attachments: LUCENE-1256.patch

Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:

# Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
# Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
# Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
# Added <span style="attrib">  to change attributions.
# In the Fancy and Simple stylesheets, change attributions are colored dark green.
# Now properly handling change attributions in CHANGES.txt that have trailing periods.
# Clicking on an anchor to expand its children now changes the document location to show the children.
# Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590613#action_12590613 ] 

Doron Cohen commented on LUCENE-1256:
-------------------------------------

Actually there are now 3 duplicates in ChangesFixedWidthStyle.css - never mind I'll remove that. 
Yes now without the setAttribute() it works for me too in IE6 as well. 
So I am committing this.


> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590617#action_12590617 ] 

Steven Rowe commented on LUCENE-1256:
-------------------------------------

One tiny display issue I noticed: the Bugzilla issue autolinkification places the </a> tag before the closing right square bracket (']') around the LUCENE-XXXX issue, so the closing bracket is not part of the link text, but it should be. 

This occurs on line #389 on changes2html.pl:

{code}
   . qq!$issue&nbsp;[LUCENE-$jira_issue_num</a>]!
{code}

should be

{code}
   . qq!$issue&nbsp;[LUCENE-$jira_issue_num]</a>!
{code}

Again, not including another patch - would you mind fixing this for me, Doron?

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-1256:
--------------------------------

    Attachment: LUCENE-1256.patch

Since the Lucene Bugzilla bugs mentioned in CHANGES.txt are no longer present in the Apache Bugzilla database, it doesn't make sense to auto-linkify these any longer.

Instead, this version of the patch links from each mentioned Bugzilla bug number to the JIRA issue that was cloned from it, and includes the JIRA issue name.  For example, the following text:

bq. ArrayIndexOutOfBoundsExceptions (patch #9110); 

becomes:

bq. ArrayIndexOutOfBoundsExceptions ([patch #9110 \[LUCENE-35\]|http://issues.apache.org/jira/browse/LUCENE-35]); 


> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-1256:
--------------------------------

    Attachment: LUCENE-1256.patch

One last bugfix: item #3.1 under 2.3.0's "New features" section is intended to be understood as a component of item #3.  This version of the patch renumbers this item to #4, like all previous versions, but it no longer includes a '1' at the beginning of the item's text, as all previous versions did.

Should hierarchical change item formatting be supported?  AFAICT, the above-described item #3.1 is the only occurrence of this phenomenon currently in CHANGES.txt.

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Issue Comment Edited: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590603#action_12590603 ] 

steve_rowe edited comment on LUCENE-1256 at 4/18/08 1:30 PM:
--------------------------------------------------------------

Hi Doron, I like the Fancy stylesheet now - thanks.  Attaching a new patch that contains a couple of small changes from your version:

# I found a way to fix the bad IE6 behavior with the dynamic Expand All/Collapse All buttons, so I removed your static <input> tags and put the button creation back in the <head><SCRIPT> tag.  I prefer this way, because the buttons will not appear at all if javascript is disabled.
# Removed an extra copy of styles in ChangesFixedWidthStyle.css
# Removed the alternative stylesheets <link> to the Fancy stylesheet (not necessary since it's the default stylesheet)


      was (Author: steve_rowe):
    Hi Doron, I like the Fancy stylesheet now - thanks.  Attaching a new patch that contains a couple of small changes from your version:

#I found a way to fix the bad IE6 behavior with the dynamic Expand All/Collapse All buttons, so I removed your static <input> tags and put the button creation back in the <head><SCRIPT> tag.  I prefer this way, because the buttons will not appear at all if javascript is disabled.
#Removed an extra copy of styles in ChangesFixedWidthStyle.css
#Removed the alternative stylesheets <link> to the Fancy stylesheet (not necessary since it's the default stylesheet)

  
> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-1256:
--------------------------------

    Attachment: LUCENE-1256.patch

Patch implementing above-described changes.

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590610#action_12590610 ] 

Steven Rowe commented on LUCENE-1256:
-------------------------------------

I just realized that I didn't save the editor buffer where I removed the extra styles from ChangesFixedWidthStyle.css -- somehow, there are *three* copies of each style in there.  Not attaching (yet another) patch - can you manually remove the extras, Doron?

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590711#action_12590711 ] 

Doron Cohen commented on LUCENE-1256:
-------------------------------------

sure np

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen resolved LUCENE-1256.
---------------------------------

       Resolution: Fixed
    Lucene Fields: [Patch Available]  (was: [Patch Available, New])

Committed, Thanks Steve!

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590605#action_12590605 ] 

Doron Cohen commented on LUCENE-1256:
-------------------------------------

I just realized that adding the buttons statically means they are shown also when javascript is disabled and then they do nothing.
I would like to have both - buttons that work also in IE6 and view that is consistent also with javascript disabled.
If this is not possible I think it is more important for IE6 to work properly. Steven?


> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590614#action_12590614 ] 

Doron Cohen commented on LUCENE-1256:
-------------------------------------

:-) second time i a row that I am to slow for your fast response... 

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen reassigned LUCENE-1256:
-----------------------------------

    Assignee: Doron Cohen

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-1256:
--------------------------------

    Attachment: LUCENE-1256.patch

One last feature: added "Expand All" and "Collapse All" buttons at the top of the page.  

These buttons are added via Javascript, so they don't appear when Javascript disabled and everything is always expanded.

This version also cleans up some mis-identified change attributions, e.g. "(see #3 above)".

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590609#action_12590609 ] 

Doron Cohen commented on LUCENE-1256:
-------------------------------------

cool, thanks, that was fast!

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Issue Comment Edited: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590614#action_12590614 ] 

doronc edited comment on LUCENE-1256 at 4/18/08 1:54 PM:
--------------------------------------------------------------

Second time in a row(e) :-) that I am too slow for your fast response... 

      was (Author: doronc):
    :-) second time i a row that I am to slow for your fast response... 
  
> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-1256:
--------------------------------

    Attachment: LUCENE-1256.patch

Hi Doron, I like the Fancy stylesheet now - thanks.  Attaching a new patch that contains a couple of small changes from your version:

#I found a way to fix the bad IE6 behavior with the dynamic Expand All/Collapse All buttons, so I removed your static <input> tags and put the button creation back in the <head><SCRIPT> tag.  I prefer this way, because the buttons will not appear at all if javascript is disabled.
#Removed an extra copy of styles in ChangesFixedWidthStyle.css
#Removed the alternative stylesheets <link> to the Fancy stylesheet (not necessary since it's the default stylesheet)


> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Assignee: Doron Cohen
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1256) Changes.html formatting improvements

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-1256:
--------------------------------

      Component/s:     (was: Build)
                   Website
    Lucene Fields: [New, Patch Available]  (was: [Patch Available, New])

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584662#action_12584662 ] 

Doron Cohen commented on LUCENE-1256:
-------------------------------------

I didn't try it but from the description it sounds great.
I'll try it over the weekend.
For the fancy stylesheet - I put those colors but no sentiments for them here - please feel free to modify them to your taste..:-)

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1256) Changes.html formatting improvements

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-1256:
--------------------------------

    Attachment: LUCENE-1256.patch

Patch looks great! 
One minor issue the dynamically inserted buttons do not work on IE 6 for me. 
I changed that to create them in the static HTML lines and now it works in both IE and FF. 
Also modified the colors of the  fancy style to be more pleasant and made it default again - for visible separation between the three parts (trunk, last release, older releases).
Attaching the update - will commit soon. 
Doron

> Changes.html formatting improvements
> ------------------------------------
>
>                 Key: LUCENE-1256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1256
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Website
>    Affects Versions: 2.4
>            Reporter: Steven Rowe
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch, LUCENE-1256.patch
>
>
> Some improvements to the Changes.html generated by the changes2html.pl script via the 'changes-to-html' ant task:
> # Simplified the Simple stylesheet (removed monospace font specification) and made it the default.  The Fancy stylesheet is really hard for me to look at (yellow text on light blue background may provide high contrast with low eye strain, but IMHO it's ugly).
> # Moved the monospace style from the Simple stylesheet to a new stylesheet named "Fixed Width"
> # Fixed syntax errors in the Fancy stylesheet, so that it displays as intended.
> # Added <span style="attrib">  to change attributions.
> # In the Fancy and Simple stylesheets, change attributions are colored dark green.
> # Now properly handling change attributions in CHANGES.txt that have trailing periods.
> # Clicking on an anchor to expand its children now changes the document location to show the children.
> # Hovering over anchors now causes a tooltip to be displayed - either "Click to expand" or "Click to collapse" - the tooltip changes appropriately after a collapse or expansion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org