You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/05/07 19:23:22 UTC

[GitHub] rob05c commented on a change in pull request #2010: Go login

rob05c commented on a change in pull request #2010: Go login
URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#discussion_r186522372
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/config/config.go
 ##########
 @@ -142,6 +156,16 @@ func LoadConfig(cdnConfPath string, dbConfPath string, riakConfPath string, appV
 		}
 	}
 
+	if cfg.LDAPConfPath != "" {
+		cfg.LDAPEnabled, cfg.ConfigLDAP, err = GetLDAPConfig(cfg.LDAPConfPath)
+		if err != nil {
+			cfg.LDAPEnabled = false // probably unnecessary
 
 Review comment:
   I'd support removing this comment. All return values should be treated as undefined, if a returned error is not nil.
   
   I'd rather omit the comment, than have someone remove the line because of the comment in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services