[GitHub] [kafka] jolshan commented on pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

["jolshan (via GitHub)" <gi...@apache.org>]

jolshan commented on PR #13868:
URL: https://github.com/apache/kafka/pull/13868#issuecomment-1595345954

   Thanks for the fix. The thread leaks have been bugging me.
   
   Did we also want to set the hw argument to false here too? https://github.com/apache/kafka/blob/48a3aab85469836f107f4fd2af03d9fa3cb4e670/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala#L4033
   
   I also noticed some lines didn't explicitly name the argument, but not sure if that's as important: https://github.com/apache/kafka/blob/48a3aab85469836f107f4fd2af03d9fa3cb4e670/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala#L142
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org