[jira] [Commented] (SPARK-7714) SparkR tests should use more specific expectations than expect_true

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609677#comment-14609677 ] 

Apache Spark commented on SPARK-7714:
-------------------------------------

User 'sun-rui' has created a pull request for this issue:
https://github.com/apache/spark/pull/7152

> SparkR tests should use more specific expectations than expect_true
> -------------------------------------------------------------------
>
>                 Key: SPARK-7714
>                 URL: https://issues.apache.org/jira/browse/SPARK-7714
>             Project: Spark
>          Issue Type: Improvement
>          Components: SparkR
>            Reporter: Josh Rosen
>
> SparkR's test use testthat's {{expect_true(foo == bar)}}, but using expectations like {{expect_equal(foo, bar)}} will give informative error messages if the assertion fails.  We should update the existing tests to use the more specific matchers, such as expect_equal, expect_is, expect_identical, expect_error, etc.
> See http://r-pkgs.had.co.nz/tests.html for more documentation on testtthat expectation functions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org