[jira] [Commented] (HADOOP-13179) TooRunner is not thread-safe because commons-cli OptionBuilder is not thread-safe

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290591#comment-15290591 ] 

Hadoop QA commented on HADOOP-13179:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 0m 3s {color} | {color:red} Docker failed to build yetus/hadoop:1886bab. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12804850/HADOOP-13179-master.patch |
| JIRA Issue | HADOOP-13179 |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9505/console |
| Powered by | Apache Yetus 0.3.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> TooRunner is not thread-safe because commons-cli OptionBuilder is not thread-safe
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-13179
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13179
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: hongbin ma
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13179-master.patch
>
>
> I'm running into similar issues like http://stackoverflow.com/questions/22462665/is-hadoops-toorunner-thread-safe, the author's observation seem to make sense to me. However when I checked the hadoop github trunk I found the issue still not fixed.
> Chris Nauroth further investigated this issue, here's his quote: 
> {quote}
> The root cause is that commons-cli OptionBuilder is not thread-safe.
> https://commons.apache.org/proper/commons-cli/apidocs/org/apache/commons/cl
> i/OptionBuilder.html
> According to this issue, commons-cli doesn't plan to change that and
> instead chose to document the lack of thread-safety.
> https://issues.apache.org/jira/browse/CLI-209
> I think we can solve this in Hadoop, probably with a one-line change to
> make GenericOptionsParser#buildGeneralOptions a synchronized method.
> {quote}
> I'll soon upload a patch for this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org